Re: [PATCH RFC 2/2] RDMA/isert: Support iWARP transport

Jason Gunthorpe
2015-06-25T18:25:05Z

On Thu, Jun 25, 2015 at 10:39:23AM -0500, Steve Wise wrote:
> + /*
> + * IWARP transports need REMOTE_WRITE for MRs used as the target of
> + * an RDMA_READ. Since the DMA MR is used for all ports, then if
> + * any port is running IWARP, add REMOTE_WRITE.
> + */
> + if (any_port_is_iwarp(device))

It would be nice to have a new-style cap test for this instead of open
coding iwarp. Similar to rdma_cap_read_multi_sge

I'm confused about the 'any_port_is_iwarp' stuff too, I thought if one
port was iwarp then all ports had to be iwarp?

Even if we move away from that, I would think that some caps must be
the same on all ports, and multi_sge, remote_write, etc would fit into
that limitation.

Jason