RE: [PATCH V2 4/5] RDMA/iser: support iWARP devices

Steve Wise
2015-06-30T14:33:21Z

> -----Original Message-----
> From: Sagi Grimberg [mailto:sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org]
> Sent: Tuesday, June 30, 2015 4:26 AM
> To: Steve Wise; dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
> Cc: roid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org; sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org; infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org;
> eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org; ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org; sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
> Subject: Re: [PATCH V2 4/5] RDMA/iser: support iWARP devices
>
> On 6/30/2015 12:36 AM, Steve Wise wrote:
> > Limit the sg tablesize based on the device fast reg depth.
> >
> > Use rdma_get_dma_mr() to allocate the DMA MR.
> >
> > Use rdma_fast_reg_access_flags() to set the access_flags for fast
> > register work requests.
>
> Steve,
>
> I wander if it would make more sense to get the iser/isert stuff in
> without the mr stuff (I'd like the mr to go in a different direction).
>
> Whatever you prefer.
>

I prefer to decouple the iSER changes with this core work. Jason/Sean... thoughts? I could do the iSER w/o patch 3, and the follow up with a series that includes our final solution on transport independent memory registration and change all the TI kernel users (iser and nfsrdma) along with it.

Steve.