From: Steve Wise <swise@opengridcomputing.com>
To: dledford@redhat.com
Cc: infinipath@intel.com, sagig@mellanox.com, ogerlitz@mellanox.com,
roid@mellanox.com, linux-rdma@vger.kernel.org, eli@mellanox.com,
target-devel@vger.kernel.org
Subject: [PATCH V5 1/5] mlx4, mlx5, mthca: Expose max_sge_rd correctly
Date: Sun, 05 Jul 2015 12:44:41 -0500 [thread overview]
Message-ID: <20150705174440.10042.86146.stgit@build2.ogc.int> (raw)
In-Reply-To: <20150705174353.10042.39648.stgit@build2.ogc.int>
From: Sagi Grimberg <sagig@mellanox.com>
Applications must not assume that max_sge and max_sge_rd are the same,
Hence expose max_sge_rd correctly as well.
Reported-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
---
drivers/infiniband/hw/mlx4/main.c | 1 +
drivers/infiniband/hw/mlx5/main.c | 1 +
drivers/infiniband/hw/mthca/mthca_provider.c | 1 +
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
index 166da78..81c342f 100644
--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/main.c
@@ -229,6 +229,7 @@ static int mlx4_ib_query_device(struct ib_device *ibdev,
props->max_qp_wr = dev->dev->caps.max_wqes - MLX4_IB_SQ_MAX_SPARE;
props->max_sge = min(dev->dev->caps.max_sq_sg,
dev->dev->caps.max_rq_sg);
+ props->max_sge_rd = props->max_sge;
props->max_cq = dev->dev->quotas.cq;
props->max_cqe = dev->dev->caps.max_cqes;
props->max_mr = dev->dev->quotas.mpt;
diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index c6cb26e..a2bcd96 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -137,6 +137,7 @@ static int mlx5_ib_query_device(struct ib_device *ibdev,
max_sq_sg = (gen->max_sq_desc_sz - sizeof(struct mlx5_wqe_ctrl_seg)) /
sizeof(struct mlx5_wqe_data_seg);
props->max_sge = min(max_rq_sg, max_sq_sg);
+ props->max_sge_rd = props->max_sge;
props->max_cq = 1 << gen->log_max_cq;
props->max_cqe = gen->max_cqes - 1;
props->max_mr = 1 << gen->log_max_mkey;
diff --git a/drivers/infiniband/hw/mthca/mthca_provider.c b/drivers/infiniband/hw/mthca/mthca_provider.c
index 93ae51d..dc2d48c 100644
--- a/drivers/infiniband/hw/mthca/mthca_provider.c
+++ b/drivers/infiniband/hw/mthca/mthca_provider.c
@@ -97,6 +97,7 @@ static int mthca_query_device(struct ib_device *ibdev, struct ib_device_attr *pr
props->max_qp = mdev->limits.num_qps - mdev->limits.reserved_qps;
props->max_qp_wr = mdev->limits.max_wqes;
props->max_sge = mdev->limits.max_sg;
+ props->max_sge_rd = props->max_sge;
props->max_cq = mdev->limits.num_cqs - mdev->limits.reserved_cqs;
props->max_cqe = mdev->limits.max_cqes;
props->max_mr = mdev->limits.num_mpts - mdev->limits.reserved_mrws;
next prev parent reply other threads:[~2015-07-05 17:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 17:44 [PATCH V5 0/5] iSER support for iWARP Steve Wise
2015-07-05 17:44 ` Steve Wise [this message]
2015-07-05 17:44 ` [PATCH V5 2/5] ipath,qib: Expose max_sge_rd correctly Steve Wise
2015-07-05 17:44 ` [PATCH V5 3/5] RDMA/iser: Limit sg tablesize and max_sectors to device fastreg max depth Steve Wise
[not found] ` <20150705174452.10042.44695.stgit-PBeJgSbIpn97NCTnQtmixQ@public.gmane.org>
2015-07-06 7:50 ` Sagi Grimberg
[not found] ` <559A335A.90506-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-07-06 14:35 ` Steve Wise
2015-07-07 6:26 ` Sagi Grimberg
2015-07-07 13:59 ` Steve Wise
2015-07-07 14:32 ` Or Gerlitz
2015-07-07 15:41 ` Steve Wise
2015-07-07 16:30 ` Sagi Grimberg
2015-07-05 17:45 ` [PATCH V5 4/5] RDMA/isert: Set REMOTE_WRITE on DMA MRs to support iWARP devices Steve Wise
[not found] ` <20150705174459.10042.37298.stgit-PBeJgSbIpn97NCTnQtmixQ@public.gmane.org>
2015-07-06 7:52 ` Sagi Grimberg
2015-07-05 17:45 ` [PATCH V5 5/5] RDMA/isert: Limit read depth based on the device max_sge_rd capability Steve Wise
[not found] ` <20150705174505.10042.28442.stgit-PBeJgSbIpn97NCTnQtmixQ@public.gmane.org>
2015-07-06 7:52 ` Sagi Grimberg
2015-07-14 8:27 ` Christoph Hellwig
[not found] ` <20150714082721.GA30072-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-07-14 14:41 ` Steve Wise
2015-07-14 15:42 ` 'Christoph Hellwig'
[not found] ` <20150714154200.GE11026-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-07-14 15:49 ` Steve Wise
2015-07-14 18:47 ` Chuck Lever
2015-07-14 19:11 ` Steve Wise
2015-07-14 19:25 ` Chuck Lever
[not found] ` <20150705174353.10042.39648.stgit-PBeJgSbIpn97NCTnQtmixQ@public.gmane.org>
2015-07-07 0:38 ` [PATCH V5 0/5] iSER support for iWARP Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150705174440.10042.86146.stgit@build2.ogc.int \
--to=swise@opengridcomputing.com \
--cc=dledford@redhat.com \
--cc=eli@mellanox.com \
--cc=infinipath@intel.com \
--cc=linux-rdma@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=roid@mellanox.com \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox