public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Steve Wise <swise@opengridcomputing.com>
To: dledford@redhat.com
Cc: infinipath@intel.com, sagig@mellanox.com, ogerlitz@mellanox.com,
	roid@mellanox.com, linux-rdma@vger.kernel.org, eli@mellanox.com,
	target-devel@vger.kernel.org
Subject: [PATCH V5 4/5] RDMA/isert: Set REMOTE_WRITE on DMA MRs to support iWARP devices
Date: Sun, 05 Jul 2015 12:45:00 -0500	[thread overview]
Message-ID: <20150705174459.10042.37298.stgit@build2.ogc.int> (raw)
In-Reply-To: <20150705174353.10042.39648.stgit@build2.ogc.int>

iWARP devices require REMOTE_WRITE for MRs used as the destination of
an RDMA READ.  So if the device protocol is iWARP, then set REMOTE_WRITE
when allocating the DMA MR.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---

 drivers/infiniband/ulp/isert/ib_isert.c |   22 +++++++++++++++++++++-
 1 files changed, 21 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
index 9e7b492..ee40478 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -348,6 +348,17 @@ out_cq:
 	return ret;
 }
 
+static int any_port_is_iwarp(struct isert_device *device)
+{
+	int i;
+
+	for (i = rdma_start_port(device->ib_device);
+	     i <= rdma_end_port(device->ib_device); i++)
+		if (rdma_protocol_iwarp(device->ib_device, i))
+			return 1;
+	return 0;
+}
+
 static int
 isert_create_device_ib_res(struct isert_device *device)
 {
@@ -383,7 +394,16 @@ isert_create_device_ib_res(struct isert_device *device)
 		goto out_cq;
 	}
 
-	device->mr = ib_get_dma_mr(device->pd, IB_ACCESS_LOCAL_WRITE);
+	/*
+	 * IWARP transports need REMOTE_WRITE for MRs used as the target of
+	 * an RDMA_READ.  Since the DMA MR is used for all ports, then if
+	 * any port is running IWARP, add REMOTE_WRITE.
+	 */
+	if (any_port_is_iwarp(device))
+		device->mr = ib_get_dma_mr(device->pd, IB_ACCESS_LOCAL_WRITE |
+						       IB_ACCESS_REMOTE_WRITE);
+	else
+		device->mr = ib_get_dma_mr(device->pd, IB_ACCESS_LOCAL_WRITE);
 	if (IS_ERR(device->mr)) {
 		ret = PTR_ERR(device->mr);
 		isert_err("failed to create dma mr, device %p, ret=%d\n",

  parent reply	other threads:[~2015-07-05 17:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-05 17:44 [PATCH V5 0/5] iSER support for iWARP Steve Wise
2015-07-05 17:44 ` [PATCH V5 1/5] mlx4, mlx5, mthca: Expose max_sge_rd correctly Steve Wise
2015-07-05 17:44 ` [PATCH V5 2/5] ipath,qib: " Steve Wise
2015-07-05 17:44 ` [PATCH V5 3/5] RDMA/iser: Limit sg tablesize and max_sectors to device fastreg max depth Steve Wise
     [not found]   ` <20150705174452.10042.44695.stgit-PBeJgSbIpn97NCTnQtmixQ@public.gmane.org>
2015-07-06  7:50     ` Sagi Grimberg
     [not found]       ` <559A335A.90506-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-07-06 14:35         ` Steve Wise
2015-07-07  6:26           ` Sagi Grimberg
2015-07-07 13:59             ` Steve Wise
2015-07-07 14:32               ` Or Gerlitz
2015-07-07 15:41                 ` Steve Wise
2015-07-07 16:30                   ` Sagi Grimberg
2015-07-05 17:45 ` Steve Wise [this message]
     [not found]   ` <20150705174459.10042.37298.stgit-PBeJgSbIpn97NCTnQtmixQ@public.gmane.org>
2015-07-06  7:52     ` [PATCH V5 4/5] RDMA/isert: Set REMOTE_WRITE on DMA MRs to support iWARP devices Sagi Grimberg
2015-07-05 17:45 ` [PATCH V5 5/5] RDMA/isert: Limit read depth based on the device max_sge_rd capability Steve Wise
     [not found]   ` <20150705174505.10042.28442.stgit-PBeJgSbIpn97NCTnQtmixQ@public.gmane.org>
2015-07-06  7:52     ` Sagi Grimberg
2015-07-14  8:27     ` Christoph Hellwig
     [not found]       ` <20150714082721.GA30072-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-07-14 14:41         ` Steve Wise
2015-07-14 15:42           ` 'Christoph Hellwig'
     [not found]             ` <20150714154200.GE11026-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-07-14 15:49               ` Steve Wise
2015-07-14 18:47                 ` Chuck Lever
2015-07-14 19:11                   ` Steve Wise
2015-07-14 19:25                     ` Chuck Lever
     [not found] ` <20150705174353.10042.39648.stgit-PBeJgSbIpn97NCTnQtmixQ@public.gmane.org>
2015-07-07  0:38   ` [PATCH V5 0/5] iSER support for iWARP Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150705174459.10042.37298.stgit@build2.ogc.int \
    --to=swise@opengridcomputing.com \
    --cc=dledford@redhat.com \
    --cc=eli@mellanox.com \
    --cc=infinipath@intel.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=roid@mellanox.com \
    --cc=sagig@mellanox.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox