From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v1 02/12] IB/core: Find the network device matching connection parameters Date: Wed, 8 Jul 2015 14:33:25 -0600 Message-ID: <20150708203325.GB16812@obsidianresearch.com> References: <1434976961-27424-1-git-send-email-haggaie@mellanox.com> <1434976961-27424-3-git-send-email-haggaie@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1434976961-27424-3-git-send-email-haggaie@mellanox.com> Sender: netdev-owner@vger.kernel.org To: Haggai Eran Cc: Doug Ledford , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, Liran Liss , Guy Shapiro , Shachar Raindel , Yotam Kenneth List-Id: linux-rdma@vger.kernel.org On Mon, Jun 22, 2015 at 03:42:31PM +0300, Haggai Eran wrote: > +/** > + * ib_get_net_dev_by_params() - Return the appropriate net_dev > + * for a received CM request > + * @dev: An RDMA device on which the request has been received. > + * @port: Port number on the RDMA device. > + * @pkey: The Pkey the request came on. > + * @gid: A GID that the net_dev uses to communicate. > + * @addr: Contains the IP address that the request specified as its > + * destination. > + */ > +struct net_device *ib_get_net_dev_by_params(struct ib_device *dev, u8 port, > + u16 pkey, const union ib_gid *gid, > + const struct sockaddr *addr); I feel like this has been repated a few times now, but kdocs should be with the function body, not in the header. Reviewed-By: Jason Gunthorpe Jason