Re: [PATCH v1 02/12] IB/core: Find the network device matching connection parameters

Haggai Eran
2015-07-09T10:18:36Z

On 08/07/2015 23:33, Jason Gunthorpe wrote:
> On Mon, Jun 22, 2015 at 03:42:31PM +0300, Haggai Eran wrote:
>> +/**
>> + * ib_get_net_dev_by_params() - Return the appropriate net_dev
>> + * for a received CM request
>> + * @dev: An RDMA device on which the request has been received.
>> + * @port: Port number on the RDMA device.
>> + * @pkey: The Pkey the request came on.
>> + * @gid: A GID that the net_dev uses to communicate.
>> + * @addr: Contains the IP address that the request specified as its
>> + * destination.
>> + */
>> +struct net_device *ib_get_net_dev_by_params(struct ib_device *dev, u8 port,
>> + u16 pkey, const union ib_gid *gid,
>> + const struct sockaddr *addr);
>
> I feel like this has been repated a few times now, but kdocs should be
> with the function body, not in the header.
Right. I fixed it in the IB/addr patch, but missed it here. I'll move it
to the function's definition.

> Reviewed-By: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Thanks,

Haggai

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html