From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v1 08/12] IB/cma: Add net_dev and private data checks to RDMA CM Date: Mon, 13 Jul 2015 12:14:14 -0600 Message-ID: <20150713181414.GJ23832@obsidianresearch.com> References: <1434976961-27424-1-git-send-email-haggaie@mellanox.com> <1434976961-27424-9-git-send-email-haggaie@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1434976961-27424-9-git-send-email-haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Haggai Eran Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Liran Liss , Guy Shapiro , Shachar Raindel , Yotam Kenneth List-Id: linux-rdma@vger.kernel.org On Mon, Jun 22, 2015 at 03:42:37PM +0300, Haggai Eran wrote: > + switch (ib_event->event) { > + case IB_CM_REQ_RECEIVED: > + req->device = req_param->listen_id->device; > + req->port = req_param->port; > + req->local_gid = &req_param->primary_path->sgid; > + req->service_id = req_param->primary_path->service_id; > + req->pkey = be16_to_cpu(req_param->primary_path->pkey); I feel pretty strongly that we should be using the pkey from the work completion, not the pkey in the message. The reason, if someone is using pkey like vlan, and expecting a container to never receive packets outside the assigned pkey, then we need to check each and every packet for the correct pkey before associating it with that container. When doing the namespace patches you should probably also look at other CM GMPs than just the REQ and how the paths are setup and consider what to do with the pkey. I'd probably suggest that the pkey should be forced throughout the entire process to ensure it always matches the ip device - at least for containers that is the right thing.. I probably wouldn't turn it on for the root namespace though.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html