From mboxrd@z Thu Jan 1 00:00:00 1970 From: 'Christoph Hellwig' Subject: Re: [PATCH V3 1/5] RDMA/core: Transport-independent access flags Date: Tue, 14 Jul 2015 08:40:31 -0700 Message-ID: <20150714154031.GD11026@infradead.org> References: <559CD174.4040901@dev.mellanox.co.il> <20150708190842.GB11740@obsidianresearch.com> <559D983D.6000804@talpey.com> <20150708233604.GA20765@obsidianresearch.com> <559E54AB.2010905@dev.mellanox.co.il> <20150709170142.GA21921@obsidianresearch.com> <20150711102538.GB14741@infradead.org> <55A4134C.2040301@talpey.com> <20150714073756.GB7630@infradead.org> <55A4D4C6.6040907@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <55A4D4C6.6040907-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg Cc: 'Christoph Hellwig' , Tom Talpey , Jason Gunthorpe , Steve Wise , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, roid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org, bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org, Oren Duer List-Id: linux-rdma@vger.kernel.org On Tue, Jul 14, 2015 at 12:22:14PM +0300, Sagi Grimberg wrote: > It's better if you want it fast. I can't stress it enough, but IMO, the > fallback should *not* be in the API, but rather in the ULP. > Ideally, at some point it won't need to fall back, and we can remove > the API. But if all driver need to impement the same dispatch between FR/FMR/ALLPHYS and having similar fast path hacks something is wrong. Maybe we should start but just implementing the helper you suggest in separae FR/FMR/ALLPHYS handlers while phasing out hacks like use ALLPHYS for single segment registrations or if other registrations fail. And as a second step we can decide if their are similar enough to consolidate them, or if we should simply kick out FMR and/or ALLPHYS and thus not support any in-kernel consumers for old HCAs. n the meantime let's kick off the now aready unuses memwindow in-kernel API (I fear the userlevel one will have to stay forever) and the about to be unused by proper in-kernel code PHYS MRs. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html