Re: [PATCH v1 02/12] IB/core: Find the network device matching connection parameters

Jason Gunthorpe
2015-07-08T20:33:25Z

On Mon, Jun 22, 2015 at 03:42:31PM +0300, Haggai Eran wrote:
> +/**
> + * ib_get_net_dev_by_params() - Return the appropriate net_dev
> + * for a received CM request
> + * @dev: An RDMA device on which the request has been received.
> + * @port: Port number on the RDMA device.
> + * @pkey: The Pkey the request came on.
> + * @gid: A GID that the net_dev uses to communicate.
> + * @addr: Contains the IP address that the request specified as its
> + * destination.
> + */
> +struct net_device *ib_get_net_dev_by_params(struct ib_device *dev, u8 port,
> + u16 pkey, const union ib_gid *gid,
> + const struct sockaddr *addr);

I feel like this has been repated a few times now, but kdocs should be
with the function body, not in the header.

Reviewed-By: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

Jason