Re: [PATCH 00/10] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

Jason Gunthorpe
2015-07-23T18:47:25Z

On Thu, Jul 23, 2015 at 11:42:11AM -0700, Bart Van Assche wrote:
> >diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
> >index fb9fed0fac28..a1e3818d0791 100644
> >+++ b/drivers/infiniband/ulp/srp/ib_srp.c
> >@@ -69,7 +69,7 @@ static unsigned int cmd_sg_entries;
> > static unsigned int indirect_sg_entries;
> > static bool allow_ext_sg;
> > static bool prefer_fr;
> >-static bool register_always;
> >+static bool register_always = true;
>
> If we want security by default then I propose not only to change the default
> value of register_always from false into true but also to change the default
> value of prefer_fr from false into true such that fast registration becomes
> the default instead of FMR.

Yes, I was frowning at that stuff too.. We are trying to get rid of
FMR, so nothing should prefer it over FRWR...

Sagi, perhaps that belongs in your MR unification series?

> >+ if (register_always)
> >+ mr_flags |= IB_ACCESS_REMOTE_READ | IB_ACCESS_REMOTE_WRITE;
>
> Hmm ... did you perhaps intend if (!register_always) instead ?

I did, thank you. For your testing convenience, the updated version is
on github now:

https://github.com/jgunthorpe/linux/commits/remove-ib_get_dma_mr

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html