Re: [PATCH 00/10] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

Doug Ledford
2015-07-29T16:39:43Z

[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]

On 07/23/2015 02:47 PM, Jason Gunthorpe wrote:
> On Thu, Jul 23, 2015 at 11:42:11AM -0700, Bart Van Assche wrote:
>>> diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
>>> index fb9fed0fac28..a1e3818d0791 100644
>>> +++ b/drivers/infiniband/ulp/srp/ib_srp.c
>>> @@ -69,7 +69,7 @@ static unsigned int cmd_sg_entries;
>>> static unsigned int indirect_sg_entries;
>>> static bool allow_ext_sg;
>>> static bool prefer_fr;
>>> -static bool register_always;
>>> +static bool register_always = true;
>>
>> If we want security by default then I propose not only to change the default
>> value of register_always from false into true but also to change the default
>> value of prefer_fr from false into true such that fast registration becomes
>> the default instead of FMR.
>
> Yes, I was frowning at that stuff too.. We are trying to get rid of
> FMR, so nothing should prefer it over FRWR...
>
> Sagi, perhaps that belongs in your MR unification series?
>
>>> + if (register_always)
>>> + mr_flags |= IB_ACCESS_REMOTE_READ | IB_ACCESS_REMOTE_WRITE;
>>
>> Hmm ... did you perhaps intend if (!register_always) instead ?
>
> I did, thank you. For your testing convenience, the updated version is
> on github now:
>
> https://github.com/jgunthorpe/linux/commits/remove-ib_get_dma_mr

Hi Jason,

If you think this is nearing a stable enough state for 4.3, please go
ahead and repost. I'm trying to pull together all of the 4.3 material
and I already have the mlx5 fix you referenced.

--
Doug Ledford <dledford@redhat.com>
GPG KeyID: 0E572FDD

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]