Re: [PATCH for-next V6 00/10] Move RoCE GID management to IB/Core

Jason Gunthorpe
2015-06-25T18:13:57Z

On Thu, Jun 25, 2015 at 11:34:43AM +0300, Or Gerlitz wrote:

> So... are we finally OK wrt the feedback you provided?

I've been looking at Yishai's series, I though it was almost good to
go, but the error flows are still wrong :(

For Matan's patch, I only looked briefly, merging it with the other
file made the diffs super hard to read for some reason. But I think it
is the right series now, and covers the right ground..

Very superficially the locking looks improved I am happy to see the
wonky smb_rmb stuff gone as well. But I stopped reading the first
series after I saw the bad use of rcu, so who knows what else in
there..

Haven't even looked at Haggai's patch considering the other two are
ahead of it. It seemed like it was covering the right ground too.

I'll try and read one of them next week, hopefully others will comment
in the mean time.

Jason