Re: [PATCH] IB/ipoib: CSUM support in connected mode

Yuval Shaia
2015-11-18T10:27:59Z

On Thu, Jul 30, 2015 at 07:03:22PM -0700, Bart Van Assche wrote:
> On 07/30/15 13:09, Yuval Shaia wrote:
> >On Thu, Jul 30, 2015 at 09:38:54AM -0700, Bart Van Assche wrote:
> >>On 07/30/2015 04:46 AM, Yuval Shaia wrote:
> >>> struct ipoib_cm_data {
> >>> __be32 qpn; /* High byte MUST be ignored on receive */
> >>> __be32 mtu;
> >>>+ __be16 sig; /* must be IPOIB_CM_PROTO_SIG */
> >>>+ __be16 caps; /* 4 bits proto ver and 12 bits capabilities */
> >>> };
> >>
> >>This patch modifies the private login data format that has been
> >>standardized by the IETF in RFC 4755. Has this modification already
> >>been discussed with the IETF ?
> >>
> >Yes.
>
> Hello Yuval,
>
> It should have been mentioned in the patch description that this
> patch modifies the wire format, how it modifies the wire format, and
Thanks,
Will add something like this:
"To support this, the Private-Data is extended (by 32 bits) with two new
attributes - protocol version and capabilities."
> also which feedback (if any) has been received so far from the IETF.
>
> Thanks,
>
> Bart.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html