From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] IB/core: Make ib_dealloc_pd return void Date: Mon, 10 Aug 2015 23:57:31 -0600 Message-ID: <20150811055731.GD13314@obsidianresearch.com> References: <20150805203431.GB30271@obsidianresearch.com> <55C39A0E.6020008@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <55C39A0E.6020008-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Chuck Lever , Sagi Grimberg , Chien Yen , Selvin Xavier , Devesh Sharma , Mitesh Ahuja List-Id: linux-rdma@vger.kernel.org On Thu, Aug 06, 2015 at 08:31:58PM +0300, Sagi Grimberg wrote: > This looks generally good. Would it make sense to go the extra mile > here and just fixup ocrdma (the only driver that seems to be able to > fail) to WARN_ON() instead of propagating an error and make it go > away from the core? I've remarked to the ocrdma folks about fixing this in the past, I'm not sure where they are on that.. There are also a few other dealloc APIs (mr, etc) that need a similar treatment. I was planning to address the ULP side and driver side in two steps to keep things simpler. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html