From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: IB/hfi1: add driver files
Date: Wed, 16 Sep 2015 10:13:07 +0300 [thread overview]
Message-ID: <20150916071307.GA29995@mwanda> (raw)
Hello Mike Marciniszyn,
The patch 7724105686e7: "IB/hfi1: add driver files" from Jul 30,
2015, leads to the following static checker warning:
drivers/staging/rdma/hfi1/user_sdma.c:1349 set_txreq_header_ahg()
warn: mask and shift to zero
drivers/staging/rdma/hfi1/user_sdma.c
1347 /* Clear KDETH.SH on last packet */
1348 if (unlikely(tx->flags & USER_SDMA_TXREQ_FLAGS_LAST_PKT)) {
1349 val |= cpu_to_le16(KDETH_GET(hdr->kdeth.ver_tid_offset,
1350 INTR) >> 16);
KDETH_GET(hdr->kdeth.ver_tid_offset, INTR) is zero or one. 1 >> 16 is
zero. This line is a no-op.
1351 val &= cpu_to_le16(~(1U << 13));
1352 AHG_HEADER_SET(req->ahg, diff, 7, 16, 14, val);
1353 } else
1354 AHG_HEADER_SET(req->ahg, diff, 7, 16, 12, val);
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2015-09-16 7:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 7:13 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-16 7:14 IB/hfi1: add driver files Dan Carpenter
2016-06-27 13:19 Dan Carpenter
2016-07-13 16:27 ` Marciniszyn, Mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916071307.GA29995@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).