* [PATCH infiniband-diags] ibcacheedit.c: Eliminate unused parameter passed to update_switchportguids
@ 2015-10-13 12:38 Hal Rosenstock
[not found] ` <561CFB2A.1030103-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Hal Rosenstock @ 2015-10-13 12:38 UTC (permalink / raw)
To: ira.weiny-ral2JQCrhuEAvxtiuMwx3w; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
src/ibcacheedit.c: In function ?update_switchportguids?:
src/ibcacheedit.c:168: warning: unused parameter ?guid?
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/src/ibcacheedit.c b/src/ibcacheedit.c
index 983c0ab..b520839 100644
--- a/src/ibcacheedit.c
+++ b/src/ibcacheedit.c
@@ -165,7 +165,7 @@ static int process_opt(void *context, int ch, char *optarg)
return 0;
}
-static void update_switchportguids(ibnd_node_t *node, uint64_t guid)
+static void update_switchportguids(ibnd_node_t *node)
{
ibnd_port_t *port;
int p;
@@ -191,7 +191,7 @@ static void replace_node_guid(ibnd_node_t *node, void *user_data)
* switches, so update port guids too
*/
if (node->type == IB_NODE_SWITCH)
- update_switchportguids(node, guids->after);
+ update_switchportguids(node);
guids->found++;
}
@@ -229,7 +229,7 @@ static void replace_portguid(ibnd_node_t *node, void *user_data)
*/
if (node->guid == guids->before) {
node->guid = guids->after;
- update_switchportguids(node, guids->after);
+ update_switchportguids(node);
guids->found++;
}
}
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH infiniband-diags] ibcacheedit.c: Eliminate unused parameter passed to update_switchportguids
[not found] ` <561CFB2A.1030103-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2015-10-13 16:52 ` ira.weiny
0 siblings, 0 replies; 2+ messages in thread
From: ira.weiny @ 2015-10-13 16:52 UTC (permalink / raw)
To: Hal Rosenstock; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Tue, Oct 13, 2015 at 08:38:02AM -0400, Hal Rosenstock wrote:
>
> src/ibcacheedit.c: In function ?update_switchportguids?:
> src/ibcacheedit.c:168: warning: unused parameter ?guid?
>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Thanks applied,
Ira
> ---
> diff --git a/src/ibcacheedit.c b/src/ibcacheedit.c
> index 983c0ab..b520839 100644
> --- a/src/ibcacheedit.c
> +++ b/src/ibcacheedit.c
> @@ -165,7 +165,7 @@ static int process_opt(void *context, int ch, char *optarg)
> return 0;
> }
>
> -static void update_switchportguids(ibnd_node_t *node, uint64_t guid)
> +static void update_switchportguids(ibnd_node_t *node)
> {
> ibnd_port_t *port;
> int p;
> @@ -191,7 +191,7 @@ static void replace_node_guid(ibnd_node_t *node, void *user_data)
> * switches, so update port guids too
> */
> if (node->type == IB_NODE_SWITCH)
> - update_switchportguids(node, guids->after);
> + update_switchportguids(node);
>
> guids->found++;
> }
> @@ -229,7 +229,7 @@ static void replace_portguid(ibnd_node_t *node, void *user_data)
> */
> if (node->guid == guids->before) {
> node->guid = guids->after;
> - update_switchportguids(node, guids->after);
> + update_switchportguids(node);
> guids->found++;
> }
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-13 16:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-13 12:38 [PATCH infiniband-diags] ibcacheedit.c: Eliminate unused parameter passed to update_switchportguids Hal Rosenstock
[not found] ` <561CFB2A.1030103-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-10-13 16:52 ` ira.weiny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).