From mboxrd@z Thu Jan 1 00:00:00 1970 From: "gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org" Subject: Re: [PATCH v2 07/22] staging/rdma/hfi1: Fix sparse error in sdma.h file Date: Sat, 24 Oct 2015 18:59:05 -0700 Message-ID: <20151025015905.GA30763@kroah.com> References: <1445307097-8244-1-git-send-email-ira.weiny@intel.com> <1445307097-8244-8-git-send-email-ira.weiny@intel.com> <20151021141231.GJ7340@mwanda> <2807E5FD2F6FDA4886F6618EAC48510E1CBCD931@CRSMSX101.amr.corp.intel.com> <20151022100125.GK7340@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20151022100125.GK7340@mwanda> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dan Carpenter Cc: "Weiny, Ira" , "devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Dalessandro, Dennis" , "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "Vishwanathapura, Niranjana" List-Id: linux-rdma@vger.kernel.org On Thu, Oct 22, 2015 at 01:01:25PM +0300, Dan Carpenter wrote: > On Wed, Oct 21, 2015 at 04:29:35PM +0000, Weiny, Ira wrote: > > > > > > On Mon, Oct 19, 2015 at 10:11:22PM -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > > > > From: Niranjana Vishwanathapura > > > > > > > > Use NULL instead of 0 for pointer argument to fix the sparse error. > > > > > > > > Reviewed-by: Mike Marciniszyn > > > > Reviewed-by: Mitko Haralanov > > > > Reviewed-by: Dennis Dalessandro > > > > Signed-off-by: Niranjana Vishwanathapura > > > > > > > > Signed-off-by: Ira Weiny > > > > > > This should have just been folded in with the previous patch. Don't introduce > > > problems and fix them in the patchset. > > > > My bad, I will fix in v3. > > I don't think it's worth redoing the patchset over because it's just a > Sparse warning, not a bug. But for the future. No, please redo, the other problems in this series warrent a new series. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html