From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] IB/sa: replace GFP_KERNEL with GFP_ATOMIC Date: Tue, 27 Oct 2015 14:00:12 -0600 Message-ID: <20151027200012.GA7403@obsidianresearch.com> References: <1445960860-3396-1-git-send-email-saurabh.truth@gmail.com> <20151027181235.GA27038@phlsvsds.ph.intel.com> <20151027181652.GA6879@obsidianresearch.com> <3F128C9216C9B84BB6ED23EF16290AFB18571E3F@CRSMSX101.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <3F128C9216C9B84BB6ED23EF16290AFB18571E3F-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Wan, Kaike" Cc: "Weiny, Ira" , Saurabh Sengar , "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "Hefty, Sean" , "hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Tue, Oct 27, 2015 at 06:56:50PM +0000, Wan, Kaike wrote: > > I do wonder if it is a good idea to call ib_nl_send_msg with a spinlock held > > though.. Would be nice to see that go away. > > We have to hold the lock to protect against a race condition that a > quick response will try to free the request from the > ib_nl_request_list before we even put it on the list. Put is on the list first? Use a kref? Doesn't look like a big deal to clean this up. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html