From mboxrd@z Thu Jan 1 00:00:00 1970 From: "ira.weiny" Subject: Re: [PATCH v3 12/23] staging/rdma/hfi1: Macro code clean up Date: Tue, 27 Oct 2015 16:51:15 -0400 Message-ID: <20151027205115.GB32118@phlsvsds.ph.intel.com> References: <1445869729-7507-1-git-send-email-ira.weiny@intel.com> <1445869729-7507-13-git-send-email-ira.weiny@intel.com> <20151027081910.GA25171@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20151027081910.GA25171-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg KH Cc: devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mitko Haralanov , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Tue, Oct 27, 2015 at 05:19:10PM +0900, Greg KH wrote: > On Mon, Oct 26, 2015 at 10:28:38AM -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > > From: Mitko Haralanov > > > > Clean up the context and sdma macros and move them to a more logical place in > > hfi.h > > > > Signed-off-by: Mitko Haralanov > > Signed-off-by: Ira Weiny > > --- > > drivers/staging/rdma/hfi1/hfi.h | 22 ++++++++++------------ > > 1 file changed, 10 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/staging/rdma/hfi1/hfi.h b/drivers/staging/rdma/hfi1/hfi.h > > index a35213e9b500..41ad9a30149b 100644 > > --- a/drivers/staging/rdma/hfi1/hfi.h > > +++ b/drivers/staging/rdma/hfi1/hfi.h > > @@ -1104,6 +1104,16 @@ struct hfi1_filedata { > > int rec_cpu_num; > > }; > > > > +/* for use in system calls, where we want to know device type, etc. */ > > +#define fp_to_fd(fp) ((struct hfi1_filedata *)(fp)->private_data) > > +#define ctxt_fp(fp) (fp_to_fd((fp))->uctxt) > > +#define subctxt_fp(fp) (fp_to_fd((fp))->subctxt) > > +#define tidcursor_fp(fp) (fp_to_fd((fp))->tidcursor) > > +#define user_sdma_pkt_fp(fp) (fp_to_fd((fp))->pq) > > +#define user_sdma_comp_fp(fp) (fp_to_fd((fp))->cq) > > +#define notifier_fp(fp) (fp_to_fd((fp))->mn) > > +#define rb_fp(fp) (fp_to_fd((fp))->tid_rb_root) > > Ick, no, don't do this, just spell it all out (odds are you will see tht > you can make the code simpler...) If you don't know what "cq" or "pq" > are, then name them properly. > > These need to be all removed. Ok. Can I add the removal of these macros to the TODO list and get this patch accepted in the interm? Many of the patches I am queueing up to submit as well as one in this series do not apply cleanly without this change. It will be much easier if I can get everything applied and then do a global clean up of these macros after the fact. Thanks, Ira -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html