From: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: shrink struct ib_send_wr V4
Date: Mon, 2 Nov 2015 16:49:22 -0800 [thread overview]
Message-ID: <20151103004922.GA22926@kroah.com> (raw)
In-Reply-To: <5637F97C.5090205-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Mon, Nov 02, 2015 at 07:02:04PM -0500, Doug Ledford wrote:
> > so overall it still benifits being in the
> > staging tree, so a few minor breakages every once in a while should be
> > easy for you to fix up, _if_ they happen.
> >
> > Again, I don't know of any recent api change that has caused any
> > problems in a long time, but the VFS developers really hate having to
> > touch lustre code, and I don't blame them, so sometimes that codebase
> > breaks. That will not affect your drivers at all, so I wouldn't worry
> > about this.
>
> Yes. I get that. And I understand that. But because of Lustre, you
> have made a global policy that effects all staging drivers without
> legitimate cause, proudly broadcast that policy at a conference, even
> answered a question from Christoph confirming that policy, and now in
> this email thread where I object to that policy you say "It doesn't
> really happen anyway, don't worry about it.'
No, it's not "because" of lustre, it's been that way since day one when
we started the staging tree. Christoph was just annoyed that someone
was trying to tell him otherwise. And he is right.
> But the person who quoted
> you (Christoph) is the author of one of the API changes that *did* break
> the RDMA drivers in the staging tree and he fixed them up when I asked
> him to. Christoph then later quoted you and his interaction with you at
> conference to indicate he didn't have to.
He didn't have to. He was being nice. That's your job to fix them up
if you want the code in staging.
> And what I'm telling him, and
> you since you are the person he's quoting to justify not fixing up
> things, is that I don't care what you say, when it comes to those
> drivers that I moved into staging, if he wants me to take his core
> patches, then he needs to make sure they don't break those drivers I
> moved into staging.
Nope, not true. If you don't like this, I'll gladly just delete the
drivers from staging, sorry. You don't get a "free ride" in staging at
all.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-03 0:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 15:13 shrink struct ib_send_wr V4 Christoph Hellwig
[not found] ` <1442157215-22341-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-09-13 15:13 ` [PATCH 2/2] IB: remove xrc_remote_srq_num from struct ib_send_wr Christoph Hellwig
2015-09-29 8:58 ` shrink struct ib_send_wr V4 Haggai Eran
2015-10-11 13:13 ` Christoph Hellwig
2015-10-29 2:25 ` Doug Ledford
[not found] ` <5631839B.30300-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-10-29 2:57 ` Doug Ledford
[not found] ` <56318B37.20207-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-10-29 11:51 ` Christoph Hellwig
[not found] ` <20151029115114.GA18466-jcswGhMUV9g@public.gmane.org>
2015-10-29 14:38 ` Doug Ledford
2015-11-01 12:10 ` Or Gerlitz
[not found] ` <56360148.8060608-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-01 18:06 ` Greg Kroah-Hartman
[not found] ` <20151101180609.GC13943-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-02 23:20 ` Doug Ledford
[not found] ` <5637EFC8.4010300-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-02 23:37 ` Greg Kroah-Hartman
[not found] ` <20151102233726.GA18251-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-03 0:02 ` Doug Ledford
[not found] ` <5637F97C.5090205-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-03 0:18 ` Jason Gunthorpe
[not found] ` <20151103001845.GA24206-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-11-03 0:49 ` Greg Kroah-Hartman
2015-11-03 0:52 ` Doug Ledford
[not found] ` <56380535.5040101-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-03 1:28 ` Jason Gunthorpe
[not found] ` <20151103012821.GA24650-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-11-03 2:03 ` Doug Ledford
[not found] ` <563815F7.2090003-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-03 4:16 ` Greg Kroah-Hartman
[not found] ` <20151103041614.GA14023-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-04 15:00 ` Doug Ledford
[not found] ` <563A1D96.2050507-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-04 17:16 ` Greg Kroah-Hartman
[not found] ` <20151104171620.GA8504-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-04 17:40 ` Doug Ledford
2015-11-03 4:38 ` Jason Gunthorpe
2015-11-03 0:49 ` Greg Kroah-Hartman [this message]
[not found] ` <20151103004922.GA22926-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-03 3:14 ` Doug Ledford
[not found] ` <5638267E.3020408-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-03 4:22 ` Greg Kroah-Hartman
2015-11-03 16:59 ` Chuck Lever
[not found] ` <D8B3250B-37D1-449B-BFA2-C4133C197AC5-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-11-03 17:43 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103004922.GA22926@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).