linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Hal Rosenstock
	<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: shrink struct ib_send_wr V4
Date: Tue, 3 Nov 2015 09:43:34 -0800	[thread overview]
Message-ID: <20151103174334.GA32580@kroah.com> (raw)
In-Reply-To: <D8B3250B-37D1-449B-BFA2-C4133C197AC5-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

On Tue, Nov 03, 2015 at 11:59:02AM -0500, Chuck Lever wrote:
> 
> > On Nov 2, 2015, at 6:37 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > 
> > On Mon, Nov 02, 2015 at 06:20:40PM -0500, Doug Ledford wrote:
> >> 1) Aging, but working, drivers that will be removed in the future.
> >> Since we no longer have a deprecation mechanism, I was informed that the
> >> normal procedure now is to move the driver to staging for a while and
> >> then remove it permanently on a future schedule.  This provides an
> >> orderly removal process.  But, if you make it so that random people can
> >> break the driver with no responsibility for fixing up their breakage, in
> >> contrast to the entire rest of the kernel, then you eliminate that
> >> orderly removal process and turn it into a completely non-deterministic
> >> and chaotic removal process.  So, no, if that's how it will be handled,
> >> I will move the deprecated drivers back to the main rdma tree and time
> >> them out and perform the orderly removal myself.
> > 
> > So you have what, one more kernel release before these are deleted?
> > Odds are, nothing is going to be broken so badly that a simple patch
> > will not fix up before they are removed.  So don't worry about this.
> > 
> > And why would you want a developer wasting time on fixing up these
> > drivers if they are about to be deleted anyway?  Obviously no one even
> > uses them, otherwise they wouldn't be about to be removed.
> 
> I understand the stated policy, but I was recently
> bitten by it. I got dinged by the kbuild robot when I
> made a change that broke something in staging. I was
> caught between the staging policy and the guidelines
> about fixing kbuild nits before a merge window.
> 
> My change was in the IB core, but the breakage was in
> Lustre. Their fix (which was quick because I had warned
> them in advance) was substantial, and not something I
> could have provided myself.
> 
> If the bits in staging are truly to be ignored, then
> the kbuild robot shouldn’t warn about new staging
> breakage. Or the warning messages should state that
> fixing said breakage is optional.

You are always free to ignore the results of the 0-day bot for stuff
like this if you want to, that's your choice, it's just informing you of
the results of the build.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2015-11-03 17:43 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-13 15:13 shrink struct ib_send_wr V4 Christoph Hellwig
     [not found] ` <1442157215-22341-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-09-13 15:13   ` [PATCH 2/2] IB: remove xrc_remote_srq_num from struct ib_send_wr Christoph Hellwig
2015-09-29  8:58   ` shrink struct ib_send_wr V4 Haggai Eran
2015-10-11 13:13   ` Christoph Hellwig
2015-10-29  2:25   ` Doug Ledford
     [not found]     ` <5631839B.30300-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-10-29  2:57       ` Doug Ledford
     [not found]         ` <56318B37.20207-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-10-29 11:51           ` Christoph Hellwig
     [not found]             ` <20151029115114.GA18466-jcswGhMUV9g@public.gmane.org>
2015-10-29 14:38               ` Doug Ledford
2015-11-01 12:10               ` Or Gerlitz
     [not found]                 ` <56360148.8060608-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-01 18:06                   ` Greg Kroah-Hartman
     [not found]                     ` <20151101180609.GC13943-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-02 23:20                       ` Doug Ledford
     [not found]                         ` <5637EFC8.4010300-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-02 23:37                           ` Greg Kroah-Hartman
     [not found]                             ` <20151102233726.GA18251-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-03  0:02                               ` Doug Ledford
     [not found]                                 ` <5637F97C.5090205-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-03  0:18                                   ` Jason Gunthorpe
     [not found]                                     ` <20151103001845.GA24206-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-11-03  0:49                                       ` Greg Kroah-Hartman
2015-11-03  0:52                                       ` Doug Ledford
     [not found]                                         ` <56380535.5040101-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-03  1:28                                           ` Jason Gunthorpe
     [not found]                                             ` <20151103012821.GA24650-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-11-03  2:03                                               ` Doug Ledford
     [not found]                                                 ` <563815F7.2090003-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-03  4:16                                                   ` Greg Kroah-Hartman
     [not found]                                                     ` <20151103041614.GA14023-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-04 15:00                                                       ` Doug Ledford
     [not found]                                                         ` <563A1D96.2050507-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-04 17:16                                                           ` Greg Kroah-Hartman
     [not found]                                                             ` <20151104171620.GA8504-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-04 17:40                                                               ` Doug Ledford
2015-11-03  4:38                                                   ` Jason Gunthorpe
2015-11-03  0:49                                   ` Greg Kroah-Hartman
     [not found]                                     ` <20151103004922.GA22926-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-03  3:14                                       ` Doug Ledford
     [not found]                                         ` <5638267E.3020408-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-03  4:22                                           ` Greg Kroah-Hartman
2015-11-03 16:59                               ` Chuck Lever
     [not found]                                 ` <D8B3250B-37D1-449B-BFA2-C4133C197AC5-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-11-03 17:43                                   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151103174334.GA32580@kroah.com \
    --to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
    --cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).