From: Dan Carpenter <dan.carpenter@oracle.com>
To: ira.weiny@intel.com
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
dledford@redhat.com, Dean Luick <dean.luick@intel.com>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH] staging/rdma/hfi1: set Gen3 half-swing for integrated devices
Date: Thu, 5 Nov 2015 10:34:48 +0300 [thread overview]
Message-ID: <20151105073448.GQ18797@mwanda> (raw)
In-Reply-To: <1446689168-21620-1-git-send-email-ira.weiny@intel.com>
On Wed, Nov 04, 2015 at 09:06:08PM -0500, ira.weiny@intel.com wrote:
> +#define CCE_PCIE_CTRL_XMT_MARGIN_GEN1_GEN2_OVERWRITE_ENABLE_MASK 0x1ull
There is absolutely no point to having a variable name which is nine
bajillion characters long since we are not able to use it and have to
instead use macro majic to hide the first twelve zillion characters. If
we can't even see the name when it is used, then why does it exist? Also
macro magic breaks grep and cscope. Just think of a better name to
begin with and get rid of the PC macro.
regards,
dan carpenter
next prev parent reply other threads:[~2015-11-05 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 2:06 [PATCH] staging/rdma/hfi1: set Gen3 half-swing for integrated devices ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-11-05 7:34 ` Dan Carpenter [this message]
2015-11-05 16:41 ` ira.weiny
2015-11-05 18:42 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151105073448.GQ18797@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dean.luick@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dledford@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).