From: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
Sebastian Sanchez
<sebastian.sanchez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] staging/rdma/hfi1: Convert dd_dev_info() to hfi1_cdbg() in process startup
Date: Thu, 5 Nov 2015 09:51:20 -0500 [thread overview]
Message-ID: <20151105145119.GA16285@phlsvsds.ph.intel.com> (raw)
In-Reply-To: <20151105075836.GS18797@mwanda>
On Thu, Nov 05, 2015 at 10:58:36AM +0300, Dan Carpenter wrote:
>On Wed, Nov 04, 2015 at 11:14:57PM -0500, jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
>> From: Sebastian Sanchez <sebastian.sanchez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>>
>> Replacing dd_dev_info() for hfi1_cdbg() to avoid generating syslog
>> output for every context that is open by PSM.
>>
>
>Just delete it... People get scared about deleting debug code but you
>can add it back if there is really a bug.
>
>/me chants, "delete. delete. delete."
I would tend to agree with that, but in this case we want to keep a way to
get this information without making code changes. We just don't want it to
spew to the console/syslog all the time. Instead we are using the trace
mechanism which lets the user selectively turn on the messages when needed.
Perhaps we should expand on the commit message to make this more clear?
-Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-05 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 4:14 [PATCH] staging/rdma/hfi1: Convert dd_dev_info() to hfi1_cdbg() in process startup jubin.john-ral2JQCrhuEAvxtiuMwx3w
2015-11-05 7:58 ` Dan Carpenter
2015-11-05 14:51 ` Dennis Dalessandro [this message]
2015-11-05 14:53 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151105145119.GA16285@phlsvsds.ph.intel.com \
--to=dennis.dalessandro-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sebastian.sanchez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).