From: Jubin John <jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH RESEND 11/11] staging/rdma/hfi1: Workaround to prevent corruption during packet delivery
Date: Mon, 9 Nov 2015 19:01:50 -0500 [thread overview]
Message-ID: <20151110000149.GA23733@phlsvsds.ph.intel.com> (raw)
In-Reply-To: <20151107032531.GA4920-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
On Fri, Nov 06, 2015 at 07:25:31PM -0800, Greg KH wrote:
> On Fri, Nov 06, 2015 at 08:07:06PM -0500, Jubin John wrote:
> > --- a/drivers/staging/rdma/hfi1/hfi.h
> > +++ b/drivers/staging/rdma/hfi1/hfi.h
> > @@ -1084,6 +1084,10 @@ struct hfi1_devdata {
> > /* Save the enabled LCB error bits */
> > u64 lcb_err_en;
> > u8 dc_shutdown;
> > +
> > + /* receive context tail dummy address */
> > + volatile __le64 *rcvhdrtail_dummy_kvaddr;
>
> There's no way that volatile here is actually correct, please fix.
>
You're right. Will fix in v2.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-11-10 0:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 1:06 [PATCH RESEND 00/11] staging/rdma/hfi1: Miscellaneous Fixes Jubin John
[not found] ` <1446858426-30509-1-git-send-email-jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-11-07 1:06 ` [PATCH RESEND 01/11] staging/rdma/hfi1: Convert dd_dev_info() to hfi1_cdbg() in process startup Jubin John
2015-11-07 1:06 ` [PATCH RESEND 02/11] staging/rdma/hfi1: Clear the QSFP reset that is asserted on FLR Jubin John
2015-11-07 1:06 ` [PATCH RESEND 03/11] staging/rdma/hfi1: Enable WFR PCIe extended tags from the driver Jubin John
2015-11-07 1:06 ` [PATCH RESEND 04/11] staging/rdma/hfi1: Always download SBus firmware Jubin John
2015-11-07 1:07 ` [PATCH RESEND 05/11] staging/rdma/hfi1: Disable thermal polling before sensor initialization Jubin John
2015-11-07 1:07 ` [PATCH RESEND 06/11] staging/rdma/hfi1: Select only devices with active links Jubin John
2015-11-07 1:07 ` [PATCH RESEND 07/11] staging/rdma/hfi1: Fix for opaportconfig ledon by not checking for portNum Jubin John
2015-11-07 1:07 ` [PATCH RESEND 08/11] staging/rdma/hfi1: Remove spurious error messages Jubin John
2015-11-07 1:07 ` [PATCH RESEND 09/11] staging/rdma/hfi1: use one-shot LCB write Jubin John
2015-11-07 1:07 ` [PATCH RESEND 10/11] staging/rdma/hfi1: Eliminate WARN_ON when VL is invalid Jubin John
[not found] ` <1446858426-30509-11-git-send-email-jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-11-07 3:26 ` Greg KH
[not found] ` <20151107032614.GB4920-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-10 0:04 ` Jubin John
2015-11-07 1:07 ` [PATCH RESEND 11/11] staging/rdma/hfi1: Workaround to prevent corruption during packet delivery Jubin John
2015-11-07 3:25 ` Greg KH
[not found] ` <20151107032531.GA4920-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-11-10 0:01 ` Jubin John [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151110000149.GA23733@phlsvsds.ph.intel.com \
--to=jubin.john-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).