From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jubin John Subject: Re: [PATCH RESEND 10/11] staging/rdma/hfi1: Eliminate WARN_ON when VL is invalid Date: Mon, 9 Nov 2015 19:04:24 -0500 Message-ID: <20151110000423.GB23733@phlsvsds.ph.intel.com> References: <1446858426-30509-1-git-send-email-jubin.john@intel.com> <1446858426-30509-11-git-send-email-jubin.john@intel.com> <20151107032614.GB4920@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20151107032614.GB4920-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg KH Cc: devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: linux-rdma@vger.kernel.org > > - if (WARN_ON(vl > 8)) > > - return NULL; > > + /* NOTE This should only happen if SC->VL changed after the initial > > + * checks on the QP/AH > > + * Default will return engine 0 below > > + */ > > + if (unlikely(vl >= num_vls)) { > > Can you prove that unlikely() makes a measured difference here? If not, > please remove it. If you can, please provide the proof in the changelog > when you resend it. Unfortunately, I can't prove this so will remove in v2. Thanks, Jubin John -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html