linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "ira.weiny" <ira.weiny@intel.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	dledford@redhat.com, Dean Luick <dean.luick@intel.com>,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2] staging/rdma/hfi1: set Gen3 half-swing for integrated devices
Date: Wed, 11 Nov 2015 10:37:08 +0300	[thread overview]
Message-ID: <20151111073708.GY18797@mwanda> (raw)
In-Reply-To: <20151110235126.GA347@phlsvsds.ph.intel.com>

That's fine.  I feel like the first option is better because those long
names really are cumbersome.  I sometimes cut and paste bugs caused by
using really long names because it's hard to spot the differences
between two really long names which are 80% the same filler text.  (I'm
using a static checker so the checker finds the bugs and I have to stare
at it for a very long time to spot the characters which are different).

regards,
dan carpenter

      reply	other threads:[~2015-11-11  7:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09 23:38 [PATCH v2] staging/rdma/hfi1: set Gen3 half-swing for integrated devices ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-11-10  9:59 ` Dan Carpenter
2015-11-10 23:51   ` ira.weiny
2015-11-11  7:37     ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151111073708.GY18797@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=dean.luick@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dledford@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ira.weiny@intel.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).