From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 4/8] staging/rdma/hfi1: remove unneeded goto done
Date: Wed, 11 Nov 2015 12:03:36 +0300 [thread overview]
Message-ID: <20151111090336.GC18797@mwanda> (raw)
In-Reply-To: <1447220589-9067-5-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Wed, Nov 11, 2015 at 12:43:05AM -0500, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
> From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> This goto done is followed by an if (ret) break in the outer switch clause. It
> is unnecessary.
>
> Signed-off-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Also these sign offs don't really make sense. Signed-off-by is
basically like signing a legal document saying the code in this patch
was not stolen from SCO UnixWare. You only need to sign if you have
handled the patch.
Did Dennis write this patch or did he Ack it or Review it somehow?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-11 9:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 5:43 [PATCH 0/8] Fix hfi1_ioctl locking ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-11-11 5:43 ` [PATCH 2/8] staging/rdma/hfi1: Fix camel case variables ira.weiny
2015-11-11 5:43 ` [PATCH 3/8] staging/rdma/hfi1: Return early from hfi1_ioctl parameter errors ira.weiny
2015-11-11 5:43 ` [PATCH 4/8] staging/rdma/hfi1: remove unneeded goto done ira.weiny
[not found] ` <1447220589-9067-5-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-11-11 9:01 ` Dan Carpenter
2015-11-11 15:15 ` ira.weiny
2015-11-11 9:03 ` Dan Carpenter [this message]
2015-11-11 14:00 ` Dennis Dalessandro
[not found] ` <1447220589-9067-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-11-11 5:43 ` [PATCH 1/8] staging/rdma/hfi1: diag.c Correct code style issues ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-11-11 5:43 ` [PATCH 5/8] staging/rdma/hfi1: return early if setlink state was specified ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-11-11 9:06 ` Dan Carpenter
2015-11-11 5:43 ` [PATCH 6/8] staging/rdma/hfi1: Further clean up hfi1_ioctl parameter checks ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-11-11 5:43 ` [PATCH 8/8] staging/rdma/hfi1: Return immediately on error ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-11-11 5:43 ` [PATCH 7/8] staging/rdma/hfi1: Reduce snoop locking scope in IOCTL handler ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111090336.GC18797@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).