From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dennis Dalessandro Subject: Re: [PATCH 4/8] staging/rdma/hfi1: remove unneeded goto done Date: Wed, 11 Nov 2015 09:00:08 -0500 Message-ID: <20151111140007.GB21044@phlsvsds.ph.intel.com> References: <1447220589-9067-1-git-send-email-ira.weiny@intel.com> <1447220589-9067-5-git-send-email-ira.weiny@intel.com> <20151111090336.GC18797@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Content-Disposition: inline In-Reply-To: <20151111090336.GC18797@mwanda> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dan Carpenter Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Wed, Nov 11, 2015 at 12:03:36PM +0300, Dan Carpenter wrote: >On Wed, Nov 11, 2015 at 12:43:05AM -0500, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: >> From: Ira Weiny >> >> This goto done is followed by an if (ret) break in the outer switch clause. It >> is unnecessary. >> >> Signed-off-by: Dennis Dalessandro >> Signed-off-by: Ira Weiny > >Also these sign offs don't really make sense. Signed-off-by is >basically like signing a legal document saying the code in this patch >was not stolen from SCO UnixWare. You only need to sign if you have >handled the patch. > >Did Dennis write this patch or did he Ack it or Review it somehow? > >regards, >dan carpenter We both participated in creating the patch(s) in this series. I think the dual signed-off-by is appropriate here. -Denny -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html