Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

[Leon Romanovsky <leon-2ukJVAZIZ/Y@public.gmane.org>]

On Wed, Nov 11, 2015 at 08:39:08AM -0500, Dennis Dalessandro wrote:
> On Wed, Nov 11, 2015 at 08:25:35AM +0200, Leon Romanovsky wrote:
> >On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
> >>From: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >>
> >>+int snoop_send_dma_handler(struct hfi1_qp *qp, struct hfi1_pkt_state *ps,
> >>+			   u64 pbc)
> >> {
> >>-	pr_alert("Snooping/Capture of  Send DMA Packets Is Not Supported!\n");
> >>+	pr_alert("Snooping/Capture of Send DMA Packets Is Not Supported!\n");
> >> 	snoop_dbg("Unsupported Operation");
> >Is it really necessary to do both print alert to message log (pr_alert) and to
> >trace buffer (snoop_dbg)?
> 
> Well yes, and no. They serve two different purposes. One for users of the
> snoop feature the other for developers.
> 
> However, I don't think we really even need to keep this function around
> anymore. How about we just remove it in a follow on patch, and let this one
> stand as is?
Sure, I'm fine with that.
> 
> -Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html