RE: [PATCH] IB/mad: In validate_mad, validate CM method and attribute

Hefty, Sean
2015-11-12T17:52:26Z

> Receipt of CM MAD with response method for other than ClassPortInfo
> attribute is invalid.
>
> CM attributes other than ClassPortInfo use send method only
> and GetResp is valid for ClassPortInfo attribute.
> Note also that the CM ClassPortInfo is not currently supported.
>
> The SRP initiator does not maintain a timeout policy for CM connect
> requests relies on the CM layer to do that. The result was that
> the SRP initiator hung as the connect request never completed.
>
> A new SRP target has been observed to respond to Send CM REQ
> with GetResp of CM REQ with bad status. This is non conformant
> with IBA spec but exposes a vulnerability in the current MAD/CM
> code which will respond to the incoming GetResp of CM REQ as if
> it was a valid incoming Send of CM REQ rather than tossing
> this on the floor. It also causes the MAD layer not to
> retransmit the original REQ even though it has not received a REP.
>
> Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
> Signed-off-by: Hal Rosenstock <hal@mellanox.com>

Reviewed-by: Sean Hefty <sean.hefty@intel.com>