Re: [PATCH 01/13] staging/rdma/hfi1: Use BIT macro

[Jubin John <jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote:
> On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote:
> > This patch fixes the checkpatch issue:
> > CHECK: Prefer using the BIT macro
> > 
> > Reviewed-by: Dean Luick <dean.luick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Reviewed-by: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Jubin John <jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > ---
> <snip>
> >  
> > diff --git a/drivers/staging/rdma/hfi1/init.c b/drivers/staging/rdma/hfi1/init.c
> > index 8666f3a..680f877 100644
> > --- a/drivers/staging/rdma/hfi1/init.c
> > +++ b/drivers/staging/rdma/hfi1/init.c
> > @@ -252,7 +252,7 @@ struct hfi1_ctxtdata *hfi1_create_ctxtdata(struct hfi1_pportdata *ppd, u32 ctxt)
> >  		/* Validate and initialize Rcv Hdr Q variables */
> >  		if (rcvhdrcnt % HDRQ_INCREMENT) {
> >  			dd_dev_err(dd,
> > -				   "ctxt%u: header queue count %d must be divisible by %d\n",
> > +				   "ctxt%u: header queue count %d must be divisible by %lud\n",
> 
> This is an unrelated change. If you are sending the series based on
> Dan's comment on 12/13 then please remove this also.
> 
This is not an unrelated change. This was needed due to the use of the
BIT macro for HDRQ_INCREMENT in chip.h.
Otherwise, the following warning is shown during the build:
drivers/staging/rdma/hfi1/init.c: In function ‘hfi1_create_ctxtdata’:
drivers/staging/rdma/hfi1/init.c:254:4: warning: format ‘%u’ expects
argument of type ‘unsigned int’, but argument 6 has type
‘long unsigned int’ [-Wformat=]
    dd_dev_err(dd,

Thanks,
Jubin John
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html