From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Bart Van Assche
<bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: srp state in current mainline
Date: Sun, 22 Nov 2015 07:10:34 -0800 [thread overview]
Message-ID: <20151122151034.GA29240@infradead.org> (raw)
In-Reply-To: <5651D775.9090500-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On Sun, Nov 22, 2015 at 04:55:49PM +0200, Sagi Grimberg wrote:
> >>Also note that 4.4-rc prefer_fr=y register_always=n
> >>!register_always still blows up badly with XFS and ext4 due to
> >>data integrity errors.
>
> So the register_always=N makes bad things happen? if we register
> all the frags we're OK (i.e. register_always=Y)?
No. register_always=Y is already broken in 4.3, but register_always=N is
now also broken in 4.4.
The 4.3+ issue that only affects register_always=Y is the FR mapping
of the indirect buffer that is not accounted for.
The 4.4+ issue that also affects register_always=N is something in your
MR patches when we hit a gappy SG list.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-22 15:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 17:15 srp state in current mainline Christoph Hellwig
[not found] ` <20151110171509.GA27781-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-11-11 15:35 ` Bart Van Assche
2015-11-11 15:46 ` Christoph Hellwig
2015-11-11 16:03 ` Bart Van Assche
[not found] ` <564366E2.8000209-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-11 16:18 ` Christoph Hellwig
[not found] ` <20151111161845.GA31542-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-11-11 16:34 ` Sagi Grimberg
2015-11-11 21:07 ` Bart Van Assche
2015-11-12 17:59 ` Christoph Hellwig
2015-11-13 1:12 ` Bart Van Assche
[not found] ` <564538EE.3050805-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-13 6:48 ` Christoph Hellwig
2015-11-15 18:06 ` Christoph Hellwig
[not found] ` <20151115180621.GA24488-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-11-15 19:48 ` Bart Van Assche
[not found] ` <5648E178.9010106-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-16 8:38 ` Christoph Hellwig
2015-11-22 13:53 ` Christoph Hellwig
2015-11-22 14:32 ` Christoph Hellwig
2015-11-22 14:55 ` Sagi Grimberg
[not found] ` <5651D775.9090500-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-11-22 15:10 ` Christoph Hellwig [this message]
2015-11-22 15:26 ` Sagi Grimberg
2015-11-22 15:31 ` Christoph Hellwig
[not found] ` <20151122153106.GA26919-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-11-24 1:14 ` Bart Van Assche
2015-11-25 19:34 ` Bart Van Assche
[not found] ` <56560D46.1070904-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-11-26 1:17 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151122151034.GA29240@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).