From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH for-next 03/10] IB/iser: Don't register memory for all immediatedata writes Date: Tue, 24 Nov 2015 11:15:56 -0700 Message-ID: <20151124181556.GE10391@obsidianresearch.com> References: <1447691861-3796-1-git-send-email-sagig@mellanox.com> <1447691861-3796-4-git-send-email-sagig@mellanox.com> <564ADB7D.20806@mellanox.com> <564AF653.6060401@dev.mellanox.co.il> <20151123181343.GB32085@obsidianresearch.com> <56543634.4090605@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56543634.4090605@dev.mellanox.co.il> Sender: target-devel-owner@vger.kernel.org To: Sagi Grimberg Cc: Or Gerlitz , Sagi Grimberg , linux-rdma@vger.kernel.org, target-devel@vger.kernel.org, "Nicholas A. Bellinger" , Steve Wise , Jenny Derzhavetz List-Id: linux-rdma@vger.kernel.org On Tue, Nov 24, 2015 at 12:04:36PM +0200, Sagi Grimberg wrote: > Jason and Or, > > > > >I'm with Or on this, this is really goofy looking. > > > >This routine probably should not be setting the rkey at all, it makes > >no sense to have a routine that returns a lkey and a rkey. Those are > >always different flows. > > > >Once that is fixed then the above if can be hoisted to the actual > >calling code that needs an rkey, at the point where it does something > >different when !iser_always_reg is true.. > > This change is acceptable to me. However, given that it includes > rework outside the scope of this specific patch which is a performance > regression fix, would it be acceptable to have it incremental and > provide a FIXME comment here? I'm not bothered by the ordering as long as we are clear where things are going :) Jason