From: "ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: Dennis Dalessandro
<dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Kamal Heib <kamalh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 05/10] IB/qib: Use rdmavt lid defines in qib
Date: Tue, 8 Dec 2015 14:24:55 -0500 [thread overview]
Message-ID: <20151208192455.GB16976@phlsvsds.ph.intel.com> (raw)
In-Reply-To: <20151207205439.GA29576-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On Mon, Dec 07, 2015 at 01:54:39PM -0700, Jason Gunthorpe wrote:
> On Mon, Dec 07, 2015 at 03:49:12PM -0500, Dennis Dalessandro wrote:
> > /* A multicast address requires a GRH (see ch. 8.4.1). */
> > - if (ah_attr->dlid >= QIB_MULTICAST_LID_BASE &&
> > - ah_attr->dlid != QIB_PERMISSIVE_LID &&
> > + if (ah_attr->dlid >= be16_to_cpu(IB_MULTICAST_LID_BASE) &&
> > + ah_attr->dlid != be16_to_cpu(IB_LID_PERMISSIVE) &&
>
> Uh cpu_to_be16 please..
But, the defines are big endian and the dlid here is cpu endian.
Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-08 19:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 20:48 [PATCH 00/10] Begin to use rdmavt for qib Dennis Dalessandro
[not found] ` <20151207204735.11219.68688.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
2015-12-07 20:48 ` [PATCH 01/10] IB/qib: Begin to use rdmavt for verbs Dennis Dalessandro
2015-12-07 20:48 ` [PATCH 02/10] IB/qib: Remove dma.c and use rdmavt version of dma functions Dennis Dalessandro
2015-12-07 20:49 ` [PATCH 03/10] IB/qib: Use rdmavt protection domain Dennis Dalessandro
[not found] ` <20151207204901.11219.30885.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
2015-12-08 10:49 ` Moni Shoua
[not found] ` <CAG9sBKNHOugvAoKYfJpvNorJR2Jih13+aeGPj0N6jVQRgBwL0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-08 23:14 ` Dennis Dalessandro
2015-12-07 20:49 ` [PATCH 04/10] IB/qib: Remove most uses of QIB_PERMISSIVE_LID and QIB_MULTICAST_LID_BASE Dennis Dalessandro
2015-12-07 20:49 ` [PATCH 05/10] IB/qib: Use rdmavt lid defines in qib Dennis Dalessandro
[not found] ` <20151207204911.11219.50129.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
2015-12-07 20:54 ` Jason Gunthorpe
[not found] ` <20151207205439.GA29576-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-12-08 19:24 ` ira.weiny [this message]
[not found] ` <20151208192455.GB16976-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-12-08 20:55 ` Jason Gunthorpe
[not found] ` <20151208205511.GA14378-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-12-08 23:19 ` Dennis Dalessandro
[not found] ` <20151208231941.GD14221-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-12-08 23:54 ` Jason Gunthorpe
2015-12-07 20:49 ` [PATCH 06/10] IB/qib: Remove driver specific members from qib qp type Dennis Dalessandro
2015-12-07 20:49 ` [PATCH 07/10] IB/qib: Add device specific info prints Dennis Dalessandro
2015-12-07 20:49 ` [PATCH 08/10] IB/qib: Remove qp and mr functionality from qib Dennis Dalessandro
2015-12-07 20:49 ` [PATCH 09/10] IB/qib: Use address handle in rdmavt and remove " Dennis Dalessandro
2015-12-07 20:49 ` [PATCH 10/10] IB/qib: Remove srq " Dennis Dalessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208192455.GB16976@phlsvsds.ph.intel.com \
--to=ira.weiny-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=kamalh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).