Re: device attr cleanup (was: Handle mlx4 max_sge_rd correctly)

[Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>]

On Wed, Dec 09, 2015 at 01:13:29AM +0200, Or Gerlitz wrote:
> 
> Christoph patch is here indeed, it does two things
> 
> 1. remove all the ULP device attr alloc, device query, attr free hassle
> 2. adds tons of new fields to struct ib_device
> 
> I think it just goes too much and needlessly adds tons of these new
> fields directly to struct ib_device where we can have them all well
> scoped into ib_device_attr member or pointer from struct ib_device

What's the benefit of that?  And looking at the existing members of
struct ib_device what determines if it goes straight into the device
or the attribute?  There is a reason why we don't do this weird
attr split in other Linux subsystems, and making IB follow this pattern
makes everyone feel right at home instead of wondering about the
weird attribute.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html