From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2 07/10] iser-target: Declare correct flags when accepting a connection Date: Wed, 9 Dec 2015 11:36:14 -0800 Message-ID: <20151209193614.GE21477@infradead.org> References: <1449663128-368-1-git-send-email-sagig@mellanox.com> <1449663128-368-8-git-send-email-sagig@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1449663128-368-8-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Or Gerlitz , Jenny Derzhavetz , "Nicholas A. Bellinger" List-Id: linux-rdma@vger.kernel.org On Wed, Dec 09, 2015 at 02:12:05PM +0200, Sagi Grimberg wrote: > From: Jenny Derzhavetz > > iser target does not support zero based virtual addresses and > send with invalidate, so it should declare that it doesn't. Only mrginally related, but can someone explain what zero based virtual addresses means in this context? Does this means it uses the old RFC5046-style header without the read/write_va fields? Or does it mean those fields exist but must always be zero? I couldn't really find a good answer in Annex A12. Otherwise looks fine: Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html