public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v3 02/11] xprtrdma: xprt_rdma_free() must not release backchannel reqs
Date: Mon, 14 Dec 2015 16:17:54 -0500	[thread overview]
Message-ID: <20151214211754.16295.84487.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20151214211317.16295.70115.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>

Preserve any rpcrdma_req that is attached to rpc_rqst's allocated
for the backchannel. Otherwise, after all the pre-allocated
backchannel req's are consumed, incoming backward calls start
writing on freed memory.

Somehow this hunk got lost.

Fixes: f531a5dbc451 ('xprtrdma: Pre-allocate backward rpc_rqst')
Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
 net/sunrpc/xprtrdma/transport.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c
index 8c545f7..740bddc 100644
--- a/net/sunrpc/xprtrdma/transport.c
+++ b/net/sunrpc/xprtrdma/transport.c
@@ -576,6 +576,9 @@ xprt_rdma_free(void *buffer)
 
 	rb = container_of(buffer, struct rpcrdma_regbuf, rg_base[0]);
 	req = rb->rg_owner;
+	if (req->rl_backchannel)
+		return;
+
 	r_xprt = container_of(req->rl_buffer, struct rpcrdma_xprt, rx_buf);
 
 	dprintk("RPC:       %s: called on 0x%p\n", __func__, req->rl_reply);

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-12-14 21:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-14 21:17 [PATCH v3 00/11] NFS/RDMA client patches for 4.5 Chuck Lever
     [not found] ` <20151214211317.16295.70115.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2015-12-14 21:17   ` [PATCH v3 01/11] xprtrdma: Fix additional uses of spin_lock_irqsave(rb_lock) Chuck Lever
2015-12-14 21:17   ` Chuck Lever [this message]
2015-12-14 21:18   ` [PATCH v3 03/11] xprtrdma: Disable RPC/RDMA backchannel debugging messages Chuck Lever
2015-12-14 21:18   ` [PATCH v3 04/11] xprtrdma: Move struct ib_send_wr off the stack Chuck Lever
     [not found]     ` <20151214211811.16295.47695.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2015-12-16 14:00       ` Sagi Grimberg
     [not found]         ` <56716E6C.4020604-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-12-16 15:06           ` Chuck Lever
     [not found]             ` <F2E992ED-2698-43DE-B7C5-4F02DA75AE42-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-12-16 15:11               ` Christoph Hellwig
     [not found]                 ` <20151216151115.GA16905-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-12-16 15:13                   ` Chuck Lever
     [not found]                     ` <D5B6F9FD-FF8F-4F37-A3E5-B287B91B1EA4-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-12-16 15:17                       ` Christoph Hellwig
2015-12-14 21:18   ` [PATCH v3 05/11] xprtrdma: Introduce ro_unmap_sync method Chuck Lever
2015-12-14 21:18   ` [PATCH v3 06/11] xprtrdma: Add ro_unmap_sync method for FRWR Chuck Lever
     [not found]     ` <20151214211827.16295.76338.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2015-12-16 13:57       ` Sagi Grimberg
     [not found]         ` <56716DE4.8080403-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-12-16 15:09           ` Chuck Lever
2015-12-14 21:18   ` [PATCH v3 07/11] xprtrdma: Add ro_unmap_sync method for FMR Chuck Lever
2015-12-14 21:19   ` [PATCH v3 08/11] xprtrdma: Add ro_unmap_sync method for all-physical registration Chuck Lever
2015-12-14 21:19   ` [PATCH v3 09/11] SUNRPC: Introduce xprt_commit_rqst() Chuck Lever
     [not found]     ` <20151214211915.16295.30339.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2015-12-16 13:48       ` Anna Schumaker
     [not found]         ` <56716BB4.8080500-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>
2015-12-16 15:12           ` Chuck Lever
2015-12-14 21:19   ` [PATCH v3 10/11] xprtrdma: Invalidate in the RPC reply handler Chuck Lever
2015-12-14 21:19   ` [PATCH v3 11/11] xprtrdma: Revert commit e7104a2a9606 ('xprtrdma: Cap req_cqinit') Chuck Lever
2015-12-15 19:37   ` [PATCH v3 00/11] NFS/RDMA client patches for 4.5 Anna Schumaker
     [not found]     ` <56706BE0.7010609-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>
2015-12-16 12:11       ` Devesh Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151214211754.16295.84487.stgit@manet.1015granger.net \
    --to=chuck.lever-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox