From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH 08/14] staging/rdma/hfi1: Start adding building blocks for TID caching Date: Thu, 17 Dec 2015 14:59:52 +0300 Message-ID: <20151217115952.GI5284@mwanda> References: <1450335624-12134-1-git-send-email-ira.weiny@intel.com> <1450335624-12134-9-git-send-email-ira.weiny@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1450335624-12134-9-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Mitko Haralanov List-Id: linux-rdma@vger.kernel.org On Thu, Dec 17, 2015 at 02:00:18AM -0500, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > +} > + > +static int program_rcvarray(struct file *fp, unsigned long vaddr, > + struct tid_group *grp, > + struct tid_pageset *sets, > + unsigned start, u16 count, struct page **pages, > + u32 *tidlist, unsigned *tididx, unsigned *pmapped) > +{ It's not clear what a zero return from this function means. Could we add some documentation? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html