Re: [PATCH rdma-next 1/6] IB/core: Save the device attributes on the device structure

ira.weiny
2015-12-19T00:50:57Z

On Fri, Dec 18, 2015 at 11:01:24AM +0200, Or Gerlitz wrote:
> On Fri, Dec 18, 2015 at 7:16 AM, ira.weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>
> > More than anything what I hate is all the places that allocate struct
> > ib_device_attr just to free it after the query call.
>
> did you care to look on patches 2-6, this is exactly what they are doing.

Yes I did. And I don't see how this statement is a problem as that is what
both your's and Christophs patches do.

If anything this was a statement in support of your series. I'm sorry you
don't see it that way.

However, if we are getting rid of query_device and the last remaining call is
in this first patch why not go all the way and remove that call site as well?

Which is why I also said:

"We discussed this patch ages ago and decided against it and FWIW It does not
hurt my feelings at all to drop it."

Ira