From: "ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: eran ben elisha
<eranlinuxmellanox-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Subject: Re: [PATCH 3/3] Display extended counter set if available
Date: Thu, 24 Dec 2015 13:45:03 -0500 [thread overview]
Message-ID: <20151224184503.GC22759@phlsvsds.ph.intel.com> (raw)
In-Reply-To: <CAKHjkjkwneRd9kTfHbQHLYMexhtP4ibE0sdHrUeYWmV=3fvYLw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, Dec 24, 2015 at 06:22:14PM +0200, eran ben elisha wrote:
> On Mon, Dec 21, 2015 at 4:20 PM, Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org> wrote:
[snip]
> >
> > +/*
> > + * Figure out which counter table to use depending on
> > + * the device capabilities.
> > + */
> > +static struct attribute_group *get_counter_table(struct ib_device *dev)
> > +{
> > + struct ib_class_port_info cpi;
> > +
> > + if (get_perf_mad(dev, 0, IB_PMA_CLASS_PORT_INFO,
>
> Why 0, need to pass port num.
> See proposal Matan and myself sent.
>
Passing a port num to a ClassPortInfo query makes no sense?
Your proposal sets a field which is wrong (I think it sets part of TrapGID if
my math is correct) in the ClassPortInfo query as per the spec.
I think the fix needs to be somewhere else.
Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-24 18:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 14:20 [PATCH 0/3] IB core: 64 bit counter support V3 Christoph Lameter
2015-12-21 14:20 ` [PATCH 1/3] Create get_perf_mad function in sysfs.c Christoph Lameter
[not found] ` <20151221142039.168096557-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
2015-12-21 17:42 ` ira.weiny
2015-12-21 14:20 ` [PATCH 2/3] Specify attribute_id in port_table_attribute Christoph Lameter
[not found] ` <20151221142039.281989535-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
2015-12-21 17:43 ` ira.weiny
2015-12-21 14:20 ` [PATCH 3/3] Display extended counter set if available Christoph Lameter
[not found] ` <20151221142039.386488696-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
2015-12-21 17:53 ` ira.weiny
[not found] ` <20151221175311.GI3860-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-12-21 17:57 ` Hal Rosenstock
[not found] ` <56783D89.4060704-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-12-21 19:31 ` Christoph Lameter
[not found] ` <alpine.DEB.2.20.1512211330290.19955-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2015-12-21 19:47 ` ira.weiny
[not found] ` <20151221194729.GK3860-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-12-21 19:52 ` Hal Rosenstock
2015-12-24 16:22 ` eran ben elisha
[not found] ` <CAKHjkjkwneRd9kTfHbQHLYMexhtP4ibE0sdHrUeYWmV=3fvYLw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-24 17:06 ` Hal Rosenstock
2015-12-24 18:45 ` ira.weiny [this message]
[not found] ` <20151221142026.238104419-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
2015-12-23 19:33 ` [PATCH 0/3] IB core: 64 bit counter support V3 Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151224184503.GC22759@phlsvsds.ph.intel.com \
--to=ira.weiny-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=eranlinuxmellanox-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).