From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 3/3] IB/srpt: Fix a race condition related to SRP login
Date: Sun, 3 Jan 2016 11:51:27 +0100 [thread overview]
Message-ID: <20160103105127.GA10025@lst.de> (raw)
In-Reply-To: <5684EE16.8070701-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
On Thu, Dec 31, 2015 at 09:57:58AM +0100, Bart Van Assche wrote:
> Since patch "IB/srpt: chain RDMA READ/WRITE requests" there are
> two loops that process the command wait list. ch->cmd_wait_list
> is accessed without locking which means that all code that
> accesses this list must be serialized. Since processing of the
> RTU event happens from another context than IB WC processing,
> remove the wait list processing code from the RTU handler.
But now the first I/O(s) could be lost if no other I/O comes in,
right? I suspect that we need to keep this loop to protect against
such corner cases.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-03 10:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 8:54 [PATCH 0/3] Three SRP driver patches for kernel 4.5 Bart Van Assche
[not found] ` <5684ED4B.2010303-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-12-31 8:56 ` [PATCH 1/3] irq_poll: Fix irq_poll_sched() Bart Van Assche
[not found] ` <5684EDA3.60802-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-03 11:15 ` Sagi Grimberg
2015-12-31 8:56 ` [PATCH 2/3] IB/srpt: Fix the RDMA completion handlers Bart Van Assche
[not found] ` <5684EDCB.30606-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-03 11:16 ` Sagi Grimberg
2015-12-31 8:57 ` [PATCH 3/3] IB/srpt: Fix a race condition related to SRP login Bart Van Assche
[not found] ` <5684EE16.8070701-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-03 10:51 ` Christoph Hellwig [this message]
[not found] ` <20160103105127.GA10025-jcswGhMUV9g@public.gmane.org>
2016-01-03 11:24 ` Sagi Grimberg
[not found] ` <56890507.9080404-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-01-03 13:01 ` Bart Van Assche
[not found] ` <56891BB8.6040502-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-03 13:09 ` Sagi Grimberg
[not found] ` <56891DA5.5060506-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-01-15 22:14 ` Bart Van Assche
2016-01-19 20:43 ` [PATCH 0/3] Three SRP driver patches for kernel 4.5 Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160103105127.GA10025@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).