* [patch] staging: rdma: shift wrapping bug in c2_get_dma_mr()
@ 2016-01-08 11:49 Dan Carpenter
2016-01-08 13:29 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2016-01-08 11:49 UTC (permalink / raw)
To: Doug Ledford, Christoph Hellwig
Cc: devel, linux-rdma, Greg Kroah-Hartman, Steve Wise,
kernel-janitors, Matan Barak, Jason Gunthorpe, Geliang Tang,
Sean Hefty, Hal Rosenstock
We should be using all 64 bits of page_list[i] instead of just the lower
32.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/rdma/amso1100/c2_provider.c b/drivers/staging/rdma/amso1100/c2_provider.c
index de8d10e..ac6a6ff 100644
--- a/drivers/staging/rdma/amso1100/c2_provider.c
+++ b/drivers/staging/rdma/amso1100/c2_provider.c
@@ -361,7 +361,7 @@ static struct ib_mr *c2_get_dma_mr(struct ib_pd *pd, int acc)
}
for (i = 0; i < pbl_depth; i++)
- page_list[i] = (i << page_shift);
+ page_list[i] = ((u64)i << page_shift);
mr = kmalloc(sizeof(*mr), GFP_KERNEL);
if (!mr) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] staging: rdma: shift wrapping bug in c2_get_dma_mr()
2016-01-08 11:49 [patch] staging: rdma: shift wrapping bug in c2_get_dma_mr() Dan Carpenter
@ 2016-01-08 13:29 ` Christoph Hellwig
2016-01-19 18:13 ` Doug Ledford
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2016-01-08 13:29 UTC (permalink / raw)
To: Dan Carpenter
Cc: Doug Ledford, Christoph Hellwig, Sean Hefty, Hal Rosenstock,
Greg Kroah-Hartman, Ira Weiny, Jason Gunthorpe, Steve Wise,
Amitoj Kaur Chawla, Matan Barak, Geliang Tang,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
Looks fine.
Doug: what's the status of the staged out drivers? I thought we were
going to delete them for 4.5?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] staging: rdma: shift wrapping bug in c2_get_dma_mr()
2016-01-08 13:29 ` Christoph Hellwig
@ 2016-01-19 18:13 ` Doug Ledford
0 siblings, 0 replies; 3+ messages in thread
From: Doug Ledford @ 2016-01-19 18:13 UTC (permalink / raw)
To: Christoph Hellwig, Dan Carpenter
Cc: Sean Hefty, Hal Rosenstock, Greg Kroah-Hartman, Ira Weiny,
Jason Gunthorpe, Steve Wise, Amitoj Kaur Chawla, Matan Barak,
Geliang Tang, linux-rdma, devel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 304 bytes --]
On 01/08/2016 08:29 AM, Christoph Hellwig wrote:
> Looks fine.
>
> Doug: what's the status of the staged out drivers? I thought we were
> going to delete them for 4.5?
>
I am. They will be going away shortly.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-19 18:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-08 11:49 [patch] staging: rdma: shift wrapping bug in c2_get_dma_mr() Dan Carpenter
2016-01-08 13:29 ` Christoph Hellwig
2016-01-19 18:13 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).