From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [patch] RDMA/nes: checking for NULL instead of IS_ERR Date: Tue, 12 Jan 2016 16:12:52 +0100 Message-ID: <20160112151252.GA2294@lst.de> References: <20160112092743.GA29804@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160112092743.GA29804@mwanda> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dan Carpenter Cc: Faisal Latif , Doug Ledford , Sean Hefty , Hal Rosenstock , Christoph Hellwig , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Tue, Jan 12, 2016 at 12:27:43PM +0300, Dan Carpenter wrote: > nes_reg_phys_mr() returns ERR_PTRs on error. It doesn't return NULL. > > This bug has been there for a while, but we recently changed from > calling a function pointer to calling nes_reg_phys_mr() directly so now > Smatch is able to detect the bug. Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html