From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH v3 00/16] add Intel X722 iWARP driver
Date: Thu, 21 Jan 2016 11:21:39 -0800 (PST) [thread overview]
Message-ID: <20160121.112139.865122294942281441.davem@davemloft.net> (raw)
In-Reply-To: <CAJ3xEMgE1-EuNBmYVfLoBwjohcxt5tio6wtZn=TYvDAgQgh9cw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
From: Or Gerlitz <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Thu, 21 Jan 2016 20:40:53 +0200
> On Thu, Jan 21, 2016 at 8:24 PM, Faisal Latif <faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>
>> We can certainly take up the discussion on improving the current port mapper design/implementation. But
>> that would be more appropriate in a separate thread.
>
> If we observe a kernel API / mechanism which could be wrongly
> duplicated between two drivers, and now a new driver comes to town
> with C&P-ing this -- why not stopping and thinking before rushing to
> get the 3rd duplication upstream?
Yes, this really looks like a huge disaster.
People have to stop doing unique APIs in their drivers, especially
when equivalent functionality exists generically.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-21 19:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 19:40 [PATCH v3 00/16] add Intel X722 iWARP driver Faisal Latif
2016-01-20 19:40 ` [PATCH v3 04/16] i40iw: add connection management code Faisal Latif
2016-01-20 19:40 ` [PATCH v3 06/16] i40iw: add pble resource files Faisal Latif
2016-01-20 19:40 ` [PATCH v3 09/16] i40iw: add files for iwarp interface Faisal Latif
2016-01-20 19:40 ` [PATCH v3 10/16] i40iw: add file to handle cqp calls Faisal Latif
2016-01-20 19:40 ` [PATCH v3 12/16] i40iw: add X722 register file Faisal Latif
[not found] ` <1453318816-21672-1-git-send-email-faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-01-20 19:40 ` [PATCH v3 01/16] i40e: Add support for client interface for IWARP driver Faisal Latif
2016-01-20 19:40 ` [PATCH v3 02/16] i40iw: add entry in rdma_netlink Faisal Latif
2016-01-20 19:40 ` [PATCH v3 03/16] i40iw: add main, hdr, status Faisal Latif
2016-01-20 19:40 ` [PATCH v3 05/16] i40iw: add puda code Faisal Latif
2016-01-20 19:40 ` [PATCH v3 07/16] i40iw: add hmc resource files Faisal Latif
2016-01-20 19:40 ` [PATCH v3 08/16] i40iw: add hw and utils files Faisal Latif
2016-01-20 19:40 ` [PATCH v3 11/16] i40iw: add hardware related header files Faisal Latif
2016-01-20 19:40 ` [PATCH v3 13/16] i40iw: user kernel shared files Faisal Latif
2016-01-20 22:24 ` [PATCH v3 00/16] add Intel X722 iWARP driver Or Gerlitz
2016-01-20 22:57 ` Steve Wise
2016-01-21 7:53 ` Or Gerlitz
[not found] ` <56A08E8F.7090602-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-01-21 15:32 ` Steve Wise
2016-01-21 17:05 ` Or Gerlitz
[not found] ` <56A10FEC.5020402-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-01-21 18:24 ` Faisal Latif
2016-01-21 18:40 ` Or Gerlitz
[not found] ` <CAJ3xEMgE1-EuNBmYVfLoBwjohcxt5tio6wtZn=TYvDAgQgh9cw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-21 19:21 ` David Miller [this message]
2016-04-04 7:39 ` Christoph Hellwig
[not found] ` <20160404073929.GA23218-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-04 17:59 ` Faisal Latif
2016-01-20 19:40 ` [PATCH v3 14/16] i40iw: virtual channel handling files Faisal Latif
2016-01-20 19:40 ` [PATCH v3 15/16] i40iw: Kconfig and Makefile for iwarp module Faisal Latif
2016-01-20 19:40 ` [PATCH v3 16/16] i40iw: changes for build of i40iw module Faisal Latif
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121.112139.865122294942281441.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).