* [PATCH] IB/sysfs: remove unused va_list args
@ 2016-01-25 17:23 Colin King
[not found] ` <1453742627-24698-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2016-01-25 17:23 UTC (permalink / raw)
To: Doug Ledford, Sean Hefty, Hal Rosenstock, Ira Weiny,
Christoph Lameter, Matan Barak, Jason Gunthorpe,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA
From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
_show_port_gid_attr performs a va_end on some unused va_list args.
Clean this up by removing the args completely.
Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
---
drivers/infiniband/core/sysfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
index 3de9351..ec46386 100644
--- a/drivers/infiniband/core/sysfs.c
+++ b/drivers/infiniband/core/sysfs.c
@@ -336,7 +336,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
union ib_gid gid;
struct ib_gid_attr gid_attr = {};
ssize_t ret;
- va_list args;
ret = ib_query_gid(p->ibdev, p->port_num, tab_attr->index, &gid,
&gid_attr);
@@ -348,7 +347,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
err:
if (gid_attr.ndev)
dev_put(gid_attr.ndev);
- va_end(args);
return ret;
}
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1453742627-24698-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>]
* Re: [PATCH] IB/sysfs: remove unused va_list args [not found] ` <1453742627-24698-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> @ 2016-01-25 17:47 ` Jason Gunthorpe 2016-01-25 18:28 ` ira.weiny 1 sibling, 0 replies; 3+ messages in thread From: Jason Gunthorpe @ 2016-01-25 17:47 UTC (permalink / raw) To: Colin King Cc: Doug Ledford, Sean Hefty, Hal Rosenstock, Ira Weiny, Christoph Lameter, Matan Barak, linux-rdma-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Mon, Jan 25, 2016 at 05:23:47PM +0000, Colin King wrote: > From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> > > _show_port_gid_attr performs a va_end on some unused va_list args. > Clean this up by removing the args completely. > > Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> Yep. This is bad new breakage too. Care to add a fixes line? Reviewed-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IB/sysfs: remove unused va_list args [not found] ` <1453742627-24698-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> 2016-01-25 17:47 ` Jason Gunthorpe @ 2016-01-25 18:28 ` ira.weiny 1 sibling, 0 replies; 3+ messages in thread From: ira.weiny @ 2016-01-25 18:28 UTC (permalink / raw) To: Colin King Cc: Doug Ledford, Sean Hefty, Hal Rosenstock, Christoph Lameter, Matan Barak, Jason Gunthorpe, linux-rdma-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Mon, Jan 25, 2016 at 05:23:47PM +0000, Colin King wrote: > From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> > > _show_port_gid_attr performs a va_end on some unused va_list args. > Clean this up by removing the args completely. > > Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > --- > drivers/infiniband/core/sysfs.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c > index 3de9351..ec46386 100644 > --- a/drivers/infiniband/core/sysfs.c > +++ b/drivers/infiniband/core/sysfs.c > @@ -336,7 +336,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p, > union ib_gid gid; > struct ib_gid_attr gid_attr = {}; > ssize_t ret; > - va_list args; > > ret = ib_query_gid(p->ibdev, p->port_num, tab_attr->index, &gid, > &gid_attr); > @@ -348,7 +347,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p, > err: > if (gid_attr.ndev) > dev_put(gid_attr.ndev); > - va_end(args); > return ret; > } > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-25 18:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-25 17:23 [PATCH] IB/sysfs: remove unused va_list args Colin King
[not found] ` <1453742627-24698-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2016-01-25 17:47 ` Jason Gunthorpe
2016-01-25 18:28 ` ira.weiny
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).