* [PATCH][V2] IB/sysfs: remove unused va_list args
@ 2016-01-25 18:38 Colin King
2016-01-25 18:41 ` ira.weiny
[not found] ` <1453747086-31000-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2016-01-25 18:38 UTC (permalink / raw)
To: Doug Ledford, Sean Hefty, Hal Rosenstock, Ira Weiny,
Christoph Lameter, Matan Barak, Jason Gunthorpe, Or Gerlitz,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kernel-team-GeWIH/nMZzLQT0dZR+AlfA
From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
_show_port_gid_attr performs a va_end on some unused va_list args.
Clean this up by removing the args completely.
Fixes: 470be516a226e8 ("IB/core: Add gid attributes to sysfs")
Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
---
drivers/infiniband/core/sysfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
index 3de9351..ec46386 100644
--- a/drivers/infiniband/core/sysfs.c
+++ b/drivers/infiniband/core/sysfs.c
@@ -336,7 +336,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
union ib_gid gid;
struct ib_gid_attr gid_attr = {};
ssize_t ret;
- va_list args;
ret = ib_query_gid(p->ibdev, p->port_num, tab_attr->index, &gid,
&gid_attr);
@@ -348,7 +347,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
err:
if (gid_attr.ndev)
dev_put(gid_attr.ndev);
- va_end(args);
return ret;
}
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][V2] IB/sysfs: remove unused va_list args
2016-01-25 18:38 [PATCH][V2] IB/sysfs: remove unused va_list args Colin King
@ 2016-01-25 18:41 ` ira.weiny
[not found] ` <1453747086-31000-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
1 sibling, 0 replies; 3+ messages in thread
From: ira.weiny @ 2016-01-25 18:41 UTC (permalink / raw)
To: Colin King
Cc: Doug Ledford, Sean Hefty, Hal Rosenstock, Christoph Lameter,
Matan Barak, Jason Gunthorpe, Or Gerlitz, linux-rdma,
linux-kernel, kernel-team
On Mon, Jan 25, 2016 at 06:38:06PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> _show_port_gid_attr performs a va_end on some unused va_list args.
> Clean this up by removing the args completely.
>
> Fixes: 470be516a226e8 ("IB/core: Add gid attributes to sysfs")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> drivers/infiniband/core/sysfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
> index 3de9351..ec46386 100644
> --- a/drivers/infiniband/core/sysfs.c
> +++ b/drivers/infiniband/core/sysfs.c
> @@ -336,7 +336,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
> union ib_gid gid;
> struct ib_gid_attr gid_attr = {};
> ssize_t ret;
> - va_list args;
>
> ret = ib_query_gid(p->ibdev, p->port_num, tab_attr->index, &gid,
> &gid_attr);
> @@ -348,7 +347,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
> err:
> if (gid_attr.ndev)
> dev_put(gid_attr.ndev);
> - va_end(args);
> return ret;
> }
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <1453747086-31000-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>]
* Re: [PATCH][V2] IB/sysfs: remove unused va_list args
[not found] ` <1453747086-31000-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
@ 2016-02-04 12:12 ` Doug Ledford
0 siblings, 0 replies; 3+ messages in thread
From: Doug Ledford @ 2016-02-04 12:12 UTC (permalink / raw)
To: Colin King, Sean Hefty, Hal Rosenstock, Ira Weiny,
Christoph Lameter, Matan Barak, Jason Gunthorpe, Or Gerlitz,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kernel-team-GeWIH/nMZzLQT0dZR+AlfA
[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]
On 01/25/2016 01:38 PM, Colin King wrote:
> From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
>
> _show_port_gid_attr performs a va_end on some unused va_list args.
> Clean this up by removing the args completely.
>
> Fixes: 470be516a226e8 ("IB/core: Add gid attributes to sysfs")
> Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> ---
> drivers/infiniband/core/sysfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
> index 3de9351..ec46386 100644
> --- a/drivers/infiniband/core/sysfs.c
> +++ b/drivers/infiniband/core/sysfs.c
> @@ -336,7 +336,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
> union ib_gid gid;
> struct ib_gid_attr gid_attr = {};
> ssize_t ret;
> - va_list args;
>
> ret = ib_query_gid(p->ibdev, p->port_num, tab_attr->index, &gid,
> &gid_attr);
> @@ -348,7 +347,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
> err:
> if (gid_attr.ndev)
> dev_put(gid_attr.ndev);
> - va_end(args);
> return ret;
> }
>
>
Thanks, applied.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-04 12:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-25 18:38 [PATCH][V2] IB/sysfs: remove unused va_list args Colin King
2016-01-25 18:41 ` ira.weiny
[not found] ` <1453747086-31000-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2016-02-04 12:12 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).