* [PATCH] IB/cm: Expose driver version
@ 2016-01-26 12:56 Yuval Shaia
[not found] ` <1453812983-23987-1-git-send-email-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Yuval Shaia @ 2016-01-26 12:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Expose driver version so admin can query it.
Initial version set to 3.18.1 as 3.18 is the latest OFED version.
Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
drivers/infiniband/core/cm.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
index 1d92e09..cb5dfeb 100644
--- a/drivers/infiniband/core/cm.c
+++ b/drivers/infiniband/core/cm.c
@@ -53,9 +53,12 @@
#include <rdma/ib_cm.h>
#include "cm_msgs.h"
+#define DRV_VERSION "3.18.1"
+
MODULE_AUTHOR("Sean Hefty");
MODULE_DESCRIPTION("InfiniBand CM");
MODULE_LICENSE("Dual BSD/GPL");
+MODULE_VERSION(DRV_VERSION);
static void cm_add_one(struct ib_device *device);
static void cm_remove_one(struct ib_device *device, void *client_data);
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/cm: Expose driver version
[not found] ` <1453812983-23987-1-git-send-email-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
@ 2016-01-26 14:54 ` Leon Romanovsky
[not found] ` <20160126145418.GB8059-2ukJVAZIZ/Y@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Leon Romanovsky @ 2016-01-26 14:54 UTC (permalink / raw)
To: Yuval Shaia; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Tue, Jan 26, 2016 at 04:56:23AM -0800, Yuval Shaia wrote:
> Expose driver version so admin can query it.
> Initial version set to 3.18.1 as 3.18 is the latest OFED version.
>
> Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/infiniband/core/cm.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
> index 1d92e09..cb5dfeb 100644
> --- a/drivers/infiniband/core/cm.c
> +++ b/drivers/infiniband/core/cm.c
> @@ -53,9 +53,12 @@
> #include <rdma/ib_cm.h>
> #include "cm_msgs.h"
>
> +#define DRV_VERSION "3.18.1"
> +
I recommend to drop this line instead of exposing.
The proper way is to use kernel version and not
specific module version which is unrelated to
anything in the real world.
> MODULE_AUTHOR("Sean Hefty");
> MODULE_DESCRIPTION("InfiniBand CM");
> MODULE_LICENSE("Dual BSD/GPL");
> +MODULE_VERSION(DRV_VERSION);
>
> static void cm_add_one(struct ib_device *device);
> static void cm_remove_one(struct ib_device *device, void *client_data);
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/cm: Expose driver version
[not found] ` <20160126145418.GB8059-2ukJVAZIZ/Y@public.gmane.org>
@ 2016-01-26 16:57 ` Yuval Shaia
2016-01-26 17:50 ` Leon Romanovsky
0 siblings, 1 reply; 4+ messages in thread
From: Yuval Shaia @ 2016-01-26 16:57 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Tue, Jan 26, 2016 at 04:54:18PM +0200, Leon Romanovsky wrote:
> On Tue, Jan 26, 2016 at 04:56:23AM -0800, Yuval Shaia wrote:
> > Expose driver version so admin can query it.
> > Initial version set to 3.18.1 as 3.18 is the latest OFED version.
> >
> > Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > ---
> > drivers/infiniband/core/cm.c | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
> > index 1d92e09..cb5dfeb 100644
> > --- a/drivers/infiniband/core/cm.c
> > +++ b/drivers/infiniband/core/cm.c
> > @@ -53,9 +53,12 @@
> > #include <rdma/ib_cm.h>
> > #include "cm_msgs.h"
> >
> > +#define DRV_VERSION "3.18.1"
> > +
>
> I recommend to drop this line instead of exposing.
> The proper way is to use kernel version and not
> specific module version which is unrelated to
> anything in the real world.
Are you suggesting not to use MODULE_VERSION at all?
Asking because i see many drivers (>600) that use it.
>
> > MODULE_AUTHOR("Sean Hefty");
> > MODULE_DESCRIPTION("InfiniBand CM");
> > MODULE_LICENSE("Dual BSD/GPL");
> > +MODULE_VERSION(DRV_VERSION);
> >
> > static void cm_add_one(struct ib_device *device);
> > static void cm_remove_one(struct ib_device *device, void *client_data);
> > --
> > 1.7.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/cm: Expose driver version
2016-01-26 16:57 ` Yuval Shaia
@ 2016-01-26 17:50 ` Leon Romanovsky
0 siblings, 0 replies; 4+ messages in thread
From: Leon Romanovsky @ 2016-01-26 17:50 UTC (permalink / raw)
To: Yuval Shaia; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Tue, Jan 26, 2016 at 06:57:06PM +0200, Yuval Shaia wrote:
> On Tue, Jan 26, 2016 at 04:54:18PM +0200, Leon Romanovsky wrote:
> > On Tue, Jan 26, 2016 at 04:56:23AM -0800, Yuval Shaia wrote:
> > > Expose driver version so admin can query it.
> > > Initial version set to 3.18.1 as 3.18 is the latest OFED version.
> > >
> > > Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > > ---
> > > drivers/infiniband/core/cm.c | 3 +++
> > > 1 files changed, 3 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
> > > index 1d92e09..cb5dfeb 100644
> > > --- a/drivers/infiniband/core/cm.c
> > > +++ b/drivers/infiniband/core/cm.c
> > > @@ -53,9 +53,12 @@
> > > #include <rdma/ib_cm.h>
> > > #include "cm_msgs.h"
> > >
> > > +#define DRV_VERSION "3.18.1"
> > > +
> >
> > I recommend to drop this line instead of exposing.
> > The proper way is to use kernel version and not
> > specific module version which is unrelated to
> > anything in the real world.
> Are you suggesting not to use MODULE_VERSION at all?
> Asking because i see many drivers (>600) that use it.
Yes, it was discussed before [1]. These drivers were coded in copy/paste
technique.
[1] https://www.mail-archive.com/linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg30201.html
> >
> > > MODULE_AUTHOR("Sean Hefty");
> > > MODULE_DESCRIPTION("InfiniBand CM");
> > > MODULE_LICENSE("Dual BSD/GPL");
> > > +MODULE_VERSION(DRV_VERSION);
> > >
> > > static void cm_add_one(struct ib_device *device);
> > > static void cm_remove_one(struct ib_device *device, void *client_data);
> > > --
> > > 1.7.1
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-26 17:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-26 12:56 [PATCH] IB/cm: Expose driver version Yuval Shaia
[not found] ` <1453812983-23987-1-git-send-email-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-01-26 14:54 ` Leon Romanovsky
[not found] ` <20160126145418.GB8059-2ukJVAZIZ/Y@public.gmane.org>
2016-01-26 16:57 ` Yuval Shaia
2016-01-26 17:50 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).