From: "leon-2ukJVAZIZ/Y@public.gmane.org" <leon-2ukJVAZIZ/Y@public.gmane.org>
To: "Estrin, Alex" <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v2] IB/ipoib: fix for rare multicast join race condition.
Date: Mon, 8 Feb 2016 15:22:45 +0200 [thread overview]
Message-ID: <20160208132245.GA13321@leon.nu> (raw)
In-Reply-To: <F3529576D8E232409F431C309E29399328F6C7FE-8k97q/ur5Z1cIJlls4ac1rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On Mon, Feb 08, 2016 at 12:23:07PM +0000, Estrin, Alex wrote:
> > 2. This function declared as a void, it is an error to add "return 0".
> >
> ipoib_mcast_join() is declared as int. Please see a very first change.
>
> > -static void ipoib_mcast_join(struct net_device *dev, struct ipoib_mcast *mcast)
> > +static int ipoib_mcast_join(struct net_device *dev, struct ipoib_mcast *mcast)
>
You are right.
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-08 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 13:50 [PATCH v2] IB/ipoib: fix for rare multicast join race condition Alex Estrin
[not found] ` <20160206135041.11630.77019.stgit-u2TXY/5TJkdZ7WVY1cDZ9q2pdiUAq4bhAL8bYrjMMd8@public.gmane.org>
2016-02-06 17:18 ` Leon Romanovsky
[not found] ` <20160206171828.GD8584-2ukJVAZIZ/Y@public.gmane.org>
2016-02-08 12:23 ` Estrin, Alex
[not found] ` <F3529576D8E232409F431C309E29399328F6C7FE-8k97q/ur5Z1cIJlls4ac1rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-02-08 13:22 ` leon-2ukJVAZIZ/Y [this message]
2016-02-08 13:34 ` Erez Shitrit
[not found] ` <CAAk-MO8b_bpb=cd0Ki7wu3sUSG_rC+fS0sxhmdn5cA-91WfR4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-08 16:43 ` Estrin, Alex
[not found] ` <F3529576D8E232409F431C309E29399328F6C892-8k97q/ur5Z1cIJlls4ac1rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-02-09 7:18 ` Leon Romanovsky
[not found] ` <20160209071847.GA14741-2ukJVAZIZ/Y@public.gmane.org>
2016-02-09 12:06 ` Estrin, Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208132245.GA13321@leon.nu \
--to=leon-2ukjvaziz/y@public.gmane.org \
--cc=alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox