From: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v2 01/12] xprtrdma: rpcrdma_bc_receive_call() should init rq_private_buf.len
Date: Thu, 18 Feb 2016 12:30:02 -0500 [thread overview]
Message-ID: <20160218173002.14009.22426.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20160218172449.14009.47311.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
Some NFSv4.1 OPEN requests were hanging waiting for the NFS server
to finish recalling delegations. Turns out that each NFSv4.1 CB
request on RDMA gets a GARBAGE_ARGS reply from the Linux client.
Commit 756b9b37cfb2e3dc added a line in bc_svc_process that
overwrites the incoming rq_rcv_buf's length with the value in
rq_private_buf.len. But rpcrdma_bc_receive_call() does not invoke
xprt_complete_bc_request(), thus rq_private_buf.len is not
initialized. svc_process_common() is invoked with a zero-length
RPC message, and fails.
Fixes: 756b9b37cfb2e3dc ('SUNRPC: Fix callback channel')
Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
net/sunrpc/xprtrdma/backchannel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/sunrpc/xprtrdma/backchannel.c b/net/sunrpc/xprtrdma/backchannel.c
index cc1251d..2dcd764 100644
--- a/net/sunrpc/xprtrdma/backchannel.c
+++ b/net/sunrpc/xprtrdma/backchannel.c
@@ -341,6 +341,8 @@ void rpcrdma_bc_receive_call(struct rpcrdma_xprt *r_xprt,
rqst->rq_reply_bytes_recvd = 0;
rqst->rq_bytes_sent = 0;
rqst->rq_xid = headerp->rm_xid;
+
+ rqst->rq_private_buf.len = size;
set_bit(RPC_BC_PA_IN_USE, &rqst->rq_bc_pa_state);
buf = &rqst->rq_rcv_buf;
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-18 17:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 17:29 [PATCH v2 00/12] NFS/RDMA client patches for v4.6 Chuck Lever
[not found] ` <20160218172449.14009.47311.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2016-02-18 17:30 ` Chuck Lever [this message]
2016-02-18 17:30 ` [PATCH v2 02/12] xprtrdma: Clean up unused RPCRDMA_INLINE_PAD_THRESH macro Chuck Lever
2016-02-18 17:30 ` [PATCH v2 03/12] xprtrdma: Clean up physical_op_map() Chuck Lever
2016-02-18 17:30 ` [PATCH v2 04/12] xprtrdma: Clean up dprintk format string containing a newline Chuck Lever
2016-02-18 17:30 ` [PATCH v2 05/12] xprtrdma: Segment head and tail XDR buffers on page boundaries Chuck Lever
2016-02-18 17:30 ` [PATCH v2 06/12] xprtrdma: Do not wait if ib_post_send() fails Chuck Lever
2016-02-18 17:30 ` [PATCH v2 07/12] rpcrdma: Add RPCRDMA_HDRLEN_ERR Chuck Lever
2016-02-18 17:30 ` [PATCH v2 08/12] xprtrdma: Properly handle RDMA_ERROR replies Chuck Lever
2016-02-18 17:31 ` [PATCH v2 09/12] xprtrdma: Serialize credit accounting again Chuck Lever
2016-02-18 17:31 ` [PATCH v2 10/12] xprtrdma: Use new CQ API for RPC-over-RDMA client receive CQs Chuck Lever
2016-02-18 17:31 ` [PATCH v2 11/12] xprtrdma: Use an anonymous union in struct rpcrdma_mw Chuck Lever
2016-02-18 17:31 ` [PATCH v2 12/12] xprtrdma: Use new CQ API for RPC-over-RDMA client send CQs Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218173002.14009.22426.stgit@manet.1015granger.net \
--to=chuck.lever-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox