From: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mike Marciniszyn
<mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: [PATCH 1/8] staging/rdma/hfi1: fix 0-day syntax error
Date: Thu, 18 Feb 2016 11:11:59 -0800 [thread overview]
Message-ID: <20160218191153.20983.21495.stgit@scvm10.sc.intel.com> (raw)
In-Reply-To: <20160218191005.20983.64127.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
From: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Setting CONFIG_HFI1_DEBUG_SDMA_ORDER causes a syntax error:
sdma.c: In function ‘complete_tx’:
sdma.c:370: error: ‘txp’ undeclared (first use in
this function)
sdma.c:370: error: (Each undeclared identifier is reported only once
sdma.c:370: error: for each function it appears in.)
Adjust code under ifdef to reference the tx properly.
Reviewed-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
drivers/staging/rdma/hfi1/sdma.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/sdma.c b/drivers/staging/rdma/hfi1/sdma.c
index 134b888..56dc54a 100644
--- a/drivers/staging/rdma/hfi1/sdma.c
+++ b/drivers/staging/rdma/hfi1/sdma.c
@@ -367,10 +367,10 @@ static inline void complete_tx(struct sdma_engine *sde,
callback_t complete = tx->complete;
#ifdef CONFIG_HFI1_DEBUG_SDMA_ORDER
- trace_hfi1_sdma_out_sn(sde, txp->sn);
- if (WARN_ON_ONCE(sde->head_sn != txp->sn))
+ trace_hfi1_sdma_out_sn(sde, tx->sn);
+ if (WARN_ON_ONCE(sde->head_sn != tx->sn))
dd_dev_err(sde->dd, "expected %llu got %llu\n",
- sde->head_sn, txp->sn);
+ sde->head_sn, tx->sn);
sde->head_sn++;
#endif
sdma_txclean(sde->dd, tx);
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-18 19:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 19:11 [PATCH 0/8] staging/rdma/hfi1,IB/rdmavt: Misc bug fixes Dennis Dalessandro
[not found] ` <20160218191005.20983.64127.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-02-18 19:11 ` Dennis Dalessandro [this message]
2016-02-18 19:12 ` [PATCH 2/8] staging/rdma/hfi1: Fix xmit discard error weight Dennis Dalessandro
2016-02-18 19:12 ` [PATCH 3/8] staging/rdma/hfi1: Cleanup comments and logs in PHY code Dennis Dalessandro
2016-02-18 19:12 ` [PATCH 4/8] staging/rdma/hfi1: Fix debugfs access race Dennis Dalessandro
2016-02-18 19:12 ` [PATCH 5/8] staging/rdma/hfi1: Disclose more information when i2c fails Dennis Dalessandro
2016-02-18 19:12 ` [PATCH 6/8] IB/rdamvt: fix cross build with rdmavt Dennis Dalessandro
2016-02-18 19:12 ` [PATCH 7/8] staging/rdma/hfi1: Guard i2c access against cp Dennis Dalessandro
2016-02-18 19:13 ` [PATCH 8/8] staging/rdma/hfi1: Fix counter read for cp Dennis Dalessandro
2016-02-18 20:39 ` [PATCH 0/8] staging/rdma/hfi1,IB/rdmavt: Misc bug fixes Leon Romanovsky
[not found] ` <20160218203923.GH30450-2ukJVAZIZ/Y@public.gmane.org>
2016-02-18 21:41 ` Dennis Dalessandro
[not found] ` <20160218214132.GA28494-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-02-19 5:18 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218191153.20983.21495.stgit@scvm10.sc.intel.com \
--to=dennis.dalessandro-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox