public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Sagi Grimberg
	<sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
	leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB/mlx5: Convert UMR CQ to new CQ API
Date: Fri, 4 Mar 2016 17:54:26 +0100	[thread overview]
Message-ID: <20160304165426.GA29122@lst.de> (raw)
In-Reply-To: <56D865AF.5000507-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Thu, Mar 03, 2016 at 11:26:23AM -0500, Doug Ledford wrote:
> I took the later version of the patch, but I had to fix it up due to
> conflicts with both the rereg_me patchset and the mmkey cleanup
> patchset.  Please double check this in the mlx5 branch of my github repo
> to make sure it's all good.

Looks like we'll need the one liner below to get the manually applied patch
to compile, but otherwise it looks fine to me.


diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
index f1464b8..4d5bff1 100644
--- a/drivers/infiniband/hw/mlx5/mr.c
+++ b/drivers/infiniband/hw/mlx5/mr.c
@@ -1201,7 +1201,7 @@ static int unreg_umr(struct mlx5_ib_dev *dev, struct mlx5_ib_mr *mr)
 
 	mlx5_ib_init_umr_context(&umr_context);
 
-	umrwr.wr.wr_cqe = &umr_context.cqe
+	umrwr.wr.wr_cqe = &umr_context.cqe;
 	prep_umr_unreg_wqe(dev, &umrwr.wr, mr->mmkey.key);
 
 	down(&umrc->sem);
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-03-04 16:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-27  9:39 use the new CQ API in the mlx5 driver Christoph Hellwig
     [not found] ` <1456565984-28998-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-27  9:39   ` [PATCH] IB/mlx5: Convert UMR CQ to new CQ API Christoph Hellwig
     [not found]     ` <1456565984-28998-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-28 11:17       ` Sagi Grimberg
     [not found]         ` <56D2D731.5060904-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-02-29  7:23           ` Haggai Eran
     [not found]             ` <56D3F1EA.9090800-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-03-03  8:38               ` Christoph Hellwig
     [not found]                 ` <20160303083822.GB13828-jcswGhMUV9g@public.gmane.org>
2016-03-03  9:06                   ` Sagi Grimberg
     [not found]                     ` <56D7FE93.9020503-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-03-03 16:26                       ` Doug Ledford
     [not found]                         ` <56D865AF.5000507-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-04 16:54                           ` Christoph Hellwig [this message]
     [not found]                             ` <20160304165426.GA29122-jcswGhMUV9g@public.gmane.org>
2016-03-04 16:56                               ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160304165426.GA29122@lst.de \
    --to=hch-jcswghmuv9g@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox